Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amd-soundwire: add support for AMD generic soundwire legacy machine driver #470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vijendarmukunda
Copy link

Add support for AMD generic legacy(No DSP) machine driver for ACP6.3 platform using RT722 codec.

Add support for AMD generic legacy(No DSP) machine driver for
ACP6.3 platform.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
@vijendarmukunda vijendarmukunda changed the title amd-soundwire: add support for AMD generic legacy machine driver amd-soundwire: add support for AMD generic soundwire legacy machine driver Nov 24, 2024
@@ -0,0 +1,81 @@
# Use case Configuration for amd-soundwire card

If.RT722 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config is almost identical to ucm2/sof-soundwire . I would add/merge code. If AMD driver follow the similar components scheme (${CardComponents} string), it can be a good benefit to share configs.

Copy link
Author

@vijendarmukunda vijendarmukunda Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perexg : Agreed. But due to time constraint, We need to release the UCM files to unblock the customer release. Let this PR go as initial version. We will look in to your suggested changes and implement the changes as next version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you show the components string ? amixer -c 0 info will print it (replace zero with the correct ALSA card number).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below is the component string output for amd-soundwire sound card.
Components : ' cfg-amp:1 hs:rt722 spk:rt722 mic:rt722'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perexg : We have identified one issue which may needs to update the UCM files. Please hold this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants