Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spdx tags: Use PSDX tags for this project #7

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Spdx tags: Use PSDX tags for this project #7

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
21afc62
COPYING: Use SPDX tags
vinodkoul Sep 9, 2020
2f3fcaf
src: use SPDX tags in C files
vinodkoul Sep 9, 2020
e832243
include: use SPDX tags in H files
vinodkoul Sep 9, 2020
4a0a95e
tinycompress: use SPDX tags in build files
vinodkoul Sep 9, 2020
b4a5d80
utils-lgpl: Add COPYING file
vinodkoul Sep 9, 2020
0250d25
fcplay: update SDPX tag style
vinodkoul Sep 9, 2020
3b6fdbf
utils-lgpl: use SPDX tags in build files
vinodkoul Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 4 additions & 53 deletions COPYING
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,54 +1,5 @@
tinycompress is provided under a dual BSD/LGPLv2.1 license. When using or
redistributing tinycompress, you may do so under either license.
tinycompress is provided under:
SPDX-License-Identifier: LGPL-2.1-only OR BSD-3-Clause
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use the same notation as in the rest of the files

SPDX-License-Identifier: (LGPL-2.1-only OR BSD-3-Clause)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should, thanks for pointing


BSD LICENSE

tinycompress library for compress audio offload in alsa
Copyright (c) 2011-2012, Intel Corporation
All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinodkoul you cannot remove the Intel Copyright.
Copyright is a different concept to the license. It's fine to use SPDX for the license, the copyright needs to stay as is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart If you look closely, the copyright is retained in src file where IMO it is apt. Here in COPYING file it feels a copy paste mistake, hence removal.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these COPYING files only provide the license, others combine license and copyright. I don't know what the rule is and I am not a lawyer, so when in doubt I am asking you to please keep the copyright as is. It may be a mistake but that's not for me to approve.


Author: Vinod Koul <vinod.koul@linux.intel.com>

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:

Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer.
Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
Neither the name of Intel Corporation nor the names of its contributors
may be used to endorse or promote products derived from this software
without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
THE POSSIBILITY OF SUCH DAMAGE.

LGPL LICENSE

tinycompress library for compress audio offload in alsa
Copyright (c) 2011-2012, Intel Corporation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, please keep the copyright for Intel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here



This program is free software; you can redistribute it and/or modify it
under the terms and conditions of the GNU Lesser General Public License,
version 2.1, as published by the Free Software Foundation.

This program is distributed in the hope it will be useful, but WITHOUT
ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public
License for more details.

You should have received a copy of the GNU Lesser General Public License
along with this program; if not, write to
the Free Software Foundation, Inc.,
51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
All contributions to the tinycompress project are subject to this COPYING
file.