fix: Move @alias onto classes instead of constructors (google#6003)

* fix: Move @alias onto classes instead of constructors

* fix: Fix JSDoc for constructors.

core/block.js

@@ -67,6 +67,7 @@ goog.require('Blockly.Events.BlockMove');
  * @implements {IASTNodeLocation}
  * @implements {IDeletable}
  * @unrestricted
+ * @alias Blockly.Block
  */
 class Block {
  /**
@@ -76,7 +77,6 @@ class Block {
  * @param {string=} opt_id Optional ID. Use this ID if provided, otherwise
  * create a new ID.
  * @throws When the prototypeName is not valid or not allowed.
- * @alias Blockly.Block
  */
  constructor(workspace, prototypeName, opt_id) {
  const {Generator} = goog.module.get('Blockly.Generator');

core/block_drag_surface.js

@@ -35,11 +35,11 @@ const {Svg} = goog.require('Blockly.utils.Svg');
 /**
  * Class for a drag surface for the currently dragged block. This is a separate
  * SVG that contains only the currently moving block, or nothing.
+ * @alias Blockly.BlockDragSurfaceSvg
  */
 const BlockDragSurfaceSvg = class {
  /**
  * @param {!Element} container Containing element.
- * @alias Blockly.BlockDragSurfaceSvg
  */
  constructor(container) {
  /**

core/block_dragger.js

@@ -43,12 +43,12 @@ goog.require('Blockly.Events.BlockMove');
  * Class for a block dragger. It moves blocks around the workspace when they
  * are being dragged by a mouse or touch.
  * @implements {IBlockDragger}
+ * @alias Blockly.BlockDragger
  */
 const BlockDragger = class {
  /**
  * @param {!BlockSvg} block The block to drag.
  * @param {!WorkspaceSvg} workspace The workspace to drag on.
- * @alias Blockly.BlockDragger
  */
  constructor(block, workspace) {
  /**

core/block_svg.js

@@ -88,6 +88,7 @@ goog.require('Blockly.Touch');
  * @implements {IBoundedElement}
  * @implements {ICopyable}
  * @implements {IDraggable}
+ * @alias Blockly.BlockSvg
  */
 class BlockSvg extends Block {
  /**
@@ -96,7 +97,6 @@ class BlockSvg extends Block {
  * type-specific functions for this block.
  * @param {string=} opt_id Optional ID. Use this ID if provided, otherwise
  * create a new ID.
- * @alias Blockly.BlockSvg
  */
  constructor(workspace, prototypeName, opt_id) {
  super(workspace, prototypeName, opt_id);

core/bubble.js

@@ -41,6 +41,7 @@ goog.require('Blockly.Workspace');
 /**
  * Class for UI bubble.
  * @implements {IBubble}
+ * @alias Blockly.Bubble
  */
 const Bubble = class {
  /**
@@ -53,7 +54,6 @@ const Bubble = class {
  * @param {?number} bubbleWidth Width of bubble, or null if not resizable.
  * @param {?number} bubbleHeight Height of bubble, or null if not resizable.
  * @struct
- * @alias Blockly.Bubble
  */
  constructor(workspace, content, shape, anchorXY, bubbleWidth, bubbleHeight) {
  this.workspace_ = workspace;

core/bubble_dragger.js

@@ -45,12 +45,12 @@ goog.require('Blockly.constants');
  * Class for a bubble dragger. It moves things on the bubble canvas around the
  * workspace when they are being dragged by a mouse or touch. These can be
  * block comments, mutators, warnings, or workspace comments.
+ * @alias Blockly.BubbleDragger
  */
 const BubbleDragger = class {
  /**
  * @param {!IBubble} bubble The item on the bubble canvas to drag.
  * @param {!WorkspaceSvg} workspace The workspace to drag on.
- * @alias Blockly.BubbleDragger
  */
  constructor(bubble, workspace) {
  /**

core/comment.js

@@ -44,11 +44,11 @@ goog.require('Blockly.Warning');
 /**
  * Class for a comment.
  * @extends {Icon}
+ * @alias Blockly.Comment
  */
 class Comment extends Icon {
  /**
  * @param {!BlockSvg} block The block associated with this comment.
- * @alias Blockly.Comment
  */
  constructor(block) {
  super(block);

core/component_manager.js

@@ -31,10 +31,11 @@ const {IPositionable} = goog.requireType('Blockly.IPositionable');
 
 /**
  * Manager for all items registered with the workspace.
+ * @alias Blockly.ComponentManager
  */
 class ComponentManager {
  /**
- * @alias Blockly.ComponentManager
+ * Creates a new ComponentManager instance.
  */
  constructor() {
  /**
@@ -219,6 +220,7 @@ ComponentManager.ComponentDatum;
 /**
  * A name with the capability of the element stored in the generic.
  * @template T
+ * @alias Blockly.ComponentManager.Capability
  */
 ComponentManager.Capability = class {
  /**

core/connection.js

@@ -38,12 +38,12 @@ goog.require('Blockly.constants');
 /**
  * Class for a connection between blocks.
  * @implements {IASTNodeLocationWithBlock}
+ * @alias Blockly.Connection
  */
 class Connection {
  /**
  * @param {!Block} source The block establishing this connection.
  * @param {number} type The type of the connection.
- * @alias Blockly.Connection
  */
  constructor(source, type) {
  /**

core/connection_checker.js

@@ -31,13 +31,9 @@ const {RenderedConnection} = goog.requireType('Blockly.RenderedConnection');
 /**
  * Class for connection type checking logic.
  * @implements {IConnectionChecker}
+ * @alias Blockly.ConnectionChecker
  */
 class ConnectionChecker {
- /**
- * @alias Blockly.ConnectionChecker
- */
- constructor() {}
-
  /**
  * Check whether the current connection can connect with the target
  * connection.

core/connection_db.js

@@ -34,13 +34,13 @@ goog.require('Blockly.constants');
  * Database of connections.
  * Connections are stored in order of their vertical component. This way
  * connections in an area may be looked up quickly using a binary search.
+ * @alias Blockly.ConnectionDB
  */
 class ConnectionDB {
  /**
  * @param {!IConnectionChecker} checker The workspace's
  * connection type checker, used to decide if connections are valid during
  * a drag.
- * @alias Blockly.ConnectionDB
  */
  constructor(checker) {
  /**

core/contextmenu_registry.js

@@ -25,10 +25,11 @@ const {WorkspaceSvg} = goog.requireType('Blockly.WorkspaceSvg');
  * Class for the registry of context menu items. This is intended to be a
  * singleton. You should not create a new instance, and only access this class
  * from ContextMenuRegistry.registry.
+ * @alias Blockly.ContextMenuRegistry
  */
 class ContextMenuRegistry {
  /**
- * @alias Blockly.ContextMenuRegistry
+ * Resets the existing singleton instance of ContextMenuRegistry.
  */
  constructor() {
  this.reset();

core/delete_area.js

@@ -31,10 +31,12 @@ const {IDraggable} = goog.requireType('Blockly.IDraggable');
  * dropped on top of it.
  * @extends {DragTarget}
  * @implements {IDeleteArea}
+ * @alias Blockly.DeleteArea
  */
 class DeleteArea extends DragTarget {
  /**
- * @alias Blockly.DeleteArea
+ * Constructor for DeleteArea. Should not be called directly, only by a
+ * subclass.
  */
  constructor() {
  super();

core/drag_target.js

@@ -30,13 +30,9 @@ const {Rect} = goog.requireType('Blockly.utils.Rect');
  * Abstract class for a component with custom behaviour when a block or bubble
  * is dragged over or dropped on top of it.
  * @implements {IDragTarget}
+ * @alias Blockly.DragTarget
  */
 class DragTarget {
- /**
- * @alias Blockly.DragTarget
- */
- constructor() {}
-
  /**
  * Handles when a cursor with a block or bubble enters this drag target.
  * @param {!IDraggable} _dragElement The block or bubble currently being

core/events/events_abstract.js

@@ -25,6 +25,7 @@ const {Workspace} = goog.requireType('Blockly.Workspace');
 /**
  * Abstract class for an event.
  * @abstract
+ * @alias Blockly.Events.Abstract
  */
 class Abstract {
  /**

core/events/events_block_base.js

@@ -23,12 +23,12 @@ const {Block} = goog.requireType('Blockly.Block');
 /**
  * Abstract class for a block event.
  * @extends {AbstractEvent}
+ * @alias Blockly.Events.BlockBase
  */
 class BlockBase extends AbstractEvent {
  /**
  * @param {!Block=} opt_block The block this event corresponds to.
  * Undefined for a blank event.
- * @alias Blockly.Events.BlockBase
  */
  constructor(opt_block) {
  super();

core/events/events_block_change.js

@@ -28,6 +28,7 @@ const {Block} = goog.requireType('Blockly.Block');
 /**
  * Class for a block change event.
  * @extends {BlockBase}
+ * @alias Blockly.Events.BlockChange
  */
 class BlockChange extends BlockBase {
  /**
@@ -37,7 +38,6 @@ class BlockChange extends BlockBase {
  * @param {?string=} opt_name Name of input or field affected, or null.
  * @param {*=} opt_oldValue Previous value of element.
  * @param {*=} opt_newValue New value of element.
- * @alias Blockly.Events.BlockChange
  */
  constructor(opt_block, opt_element, opt_name, opt_oldValue, opt_newValue) {
  super(opt_block);

core/events/events_block_create.js

@@ -27,12 +27,12 @@ const {Block} = goog.requireType('Blockly.Block');
 /**
  * Class for a block creation event.
  * @extends {BlockBase}
+ * @alias Blockly.Events.BlockCreate
  */
 class BlockCreate extends BlockBase {
  /**
  * @param {!Block=} opt_block The created block. Undefined for a blank
  * event.
- * @alias Blockly.Events.BlockCreate
  */
  constructor(opt_block) {
  super(opt_block);

core/events/events_block_delete.js

@@ -27,12 +27,12 @@ const {Block} = goog.requireType('Blockly.Block');
 /**
  * Class for a block deletion event.
  * @extends {BlockBase}
+ * @alias Blockly.Events.BlockDelete
  */
 class BlockDelete extends BlockBase {
  /**
  * @param {!Block=} opt_block The deleted block. Undefined for a blank
  * event.
- * @alias Blockly.Events.BlockDelete
  */
  constructor(opt_block) {
  super(opt_block);

core/events/events_block_drag.js

@@ -25,6 +25,7 @@ const {UiBase} = goog.require('Blockly.Events.UiBase');
 /**
  * Class for a block drag event.
  * @extends {UiBase}
+ * @alias Blockly.Events.BlockDrag
  */
 class BlockDrag extends UiBase {
  /**
@@ -34,7 +35,6 @@ class BlockDrag extends UiBase {
  * Undefined for a blank event.
  * @param {!Array<!Block>=} opt_blocks The blocks affected by this
  * drag. Undefined for a blank event.
- * @alias Blockly.Events.BlockDrag
  */
  constructor(opt_block, opt_isStart, opt_blocks) {
  const workspaceId = opt_block ? opt_block.workspace.id : undefined;

core/events/events_block_move.js

@@ -27,12 +27,12 @@ const {Coordinate} = goog.require('Blockly.utils.Coordinate');
 /**
  * Class for a block move event. Created before the move.
  * @extends {BlockBase}
+ * @alias Blockly.Events.BlockMove
  */
 class BlockMove extends BlockBase {
  /**
  * @param {!Block=} opt_block The moved block. Undefined for a blank
  * event.
- * @alias Blockly.Events.BlockMove
  */
  constructor(opt_block) {
  super(opt_block);

core/events/events_bubble_open.js

@@ -25,6 +25,7 @@ const {UiBase} = goog.require('Blockly.Events.UiBase');
 /**
  * Class for a bubble open event.
  * @extends {UiBase}
+ * @alias Blockly.Events.BubbleOpen
  */
 class BubbleOpen extends UiBase {
  /**
@@ -35,7 +36,6 @@ class BubbleOpen extends UiBase {
  * @param {string=} opt_bubbleType The type of bubble. One of 'mutator',
  * 'comment'
  * or 'warning'. Undefined for a blank event.
- * @alias Blockly.Events.BubbleOpen
  */
  constructor(opt_block, opt_isOpen, opt_bubbleType) {
  const workspaceId = opt_block ? opt_block.workspace.id : undefined;

core/events/events_click.js

@@ -25,6 +25,7 @@ const {UiBase} = goog.require('Blockly.Events.UiBase');
 /**
  * Class for a click event.
  * @extends {UiBase}
+ * @alias Blockly.Events.Click
  */
 class Click extends UiBase {
  /**
@@ -35,7 +36,6 @@ class Click extends UiBase {
  * Not used if block is passed. Undefined for a blank event.
  * @param {string=} opt_targetType The type of element targeted by this click
  * event. Undefined for a blank event.
- * @alias Blockly.Events.Click
  */
  constructor(opt_block, opt_workspaceId, opt_targetType) {
  let workspaceId = opt_block ? opt_block.workspace.id : opt_workspaceId;

core/events/events_comment_base.js

@@ -30,12 +30,12 @@ const {WorkspaceComment} = goog.requireType('Blockly.WorkspaceComment');
 /**
  * Abstract class for a comment event.
  * @extends {AbstractEvent}
+ * @alias Blockly.Events.CommentBase
  */
 class CommentBase extends AbstractEvent {
  /**
  * @param {!WorkspaceComment=} opt_comment The comment this event
  * corresponds to. Undefined for a blank event.
- * @alias Blockly.Events.CommentBase
  */
  constructor(opt_comment) {
  super();

core/events/events_comment_change.js

@@ -25,14 +25,14 @@ const {WorkspaceComment} = goog.requireType('Blockly.WorkspaceComment');
 /**
  * Class for a comment change event.
  * @extends {CommentBase}
+ * @alias Blockly.Events.CommentChange
  */
 class CommentChange extends CommentBase {
  /**
  * @param {!WorkspaceComment=} opt_comment The comment that is being
  * changed. Undefined for a blank event.
  * @param {string=} opt_oldContents Previous contents of the comment.
  * @param {string=} opt_newContents New contents of the comment.
- * @alias Blockly.Events.CommentChange
  */
  constructor(opt_comment, opt_oldContents, opt_newContents) {
  super(opt_comment);

core/events/events_comment_create.js

@@ -26,12 +26,12 @@ const {WorkspaceComment} = goog.requireType('Blockly.WorkspaceComment');
 /**
  * Class for a comment creation event.
  * @extends {CommentBase}
+ * @alias Blockly.Events.CommentCreate
  */
 class CommentCreate extends CommentBase {
  /**
  * @param {!WorkspaceComment=} opt_comment The created comment.
  * Undefined for a blank event.
- * @alias Blockly.Events.CommentCreate
  */
  constructor(opt_comment) {
  super(opt_comment);

core/events/events_comment_delete.js

@@ -25,12 +25,12 @@ const {WorkspaceComment} = goog.requireType('Blockly.WorkspaceComment');
 /**
  * Class for a comment deletion event.
  * @extends {CommentBase}
+ * @alias Blockly.Events.CommentDelete
  */
 class CommentDelete extends CommentBase {
  /**
  * @param {!WorkspaceComment=} opt_comment The deleted comment.
  * Undefined for a blank event.
- * @alias Blockly.Events.CommentDelete
  */
  constructor(opt_comment) {
  super(opt_comment);