Skip to content

Commit

Permalink
fix: do not included downloaded assets in jekyll-minifier (#2749)
Browse files Browse the repository at this point in the history
If `download: true`, the site deployment fails.
This caused e.g. issue #2548.

I believe the issue appears because the 3rd party downloaded libs rely
on ES6 Syntax, which jekyll-minifier cannot work on correctly.
Also, I think we do not need to minify 3rd party downloaded libs at all.

While this PR does **not** fix the issue above, it at least ensures that
the site can be deployed with `download: true`. We still need better ES6
support as suggested in #2571.
  • Loading branch information
CheariX authored Oct 5, 2024
1 parent b74b292 commit 421bdf8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ sass:
# -----------------------------------------------------------------------------

jekyll-minifier:
exclude: ["robots.txt", "assets/js/search/*.js"]
exclude: ["robots.txt", "assets/js/search/*.js", "assets/libs/**/*"]
uglifier_args:
harmony: true

Expand Down

0 comments on commit 421bdf8

Please sign in to comment.