-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid hardcoded socials ordering #2882
Comments
Just to be clear, your idea is to move the social code to a yml file, then in the |
That's the idea yes. I agree that this does not solve merge issues but it does allow for an easy re-ordering of the icons. |
This is kind of easy to implement, so I can do it. But only after I can fix the missing piece to merge #2866. I really struggle with small pieces of front end details. |
This is great, I'm actually looking forward to rebasing now 😎 thanks! |
Fixes alshedivat#2882, added support for [scholar-icons](https://github.com/louisfacun/scholar-icons) and [LeetCode](https://leetcode.com/). --------- Signed-off-by: George Araújo <george.gcac@gmail.com>
Have you checked that your feature request isn't already filed?
Description & Motivation
No response
Pitch
ATM, the order of socials links at the bottom of about pages are hardcoded to an arbitrary (non-alphabetical) ordering.
To sort them, one has to adjust the liquid template which makes it more difficult to later update one's website by rebasing to the main branch.
Alternatives
In my opinion, a neater way would be to keep socials info in
_data/
and leave it up to users to (re)define the list of chosen socials in yaml.Added benefit: in most cases, all one needs is a URL and an icon string (font awesome or academicons etc).
If there was a YAML data structure that contains entries with these two, you do not need to add anything to the main template to enable users to add new socials by just providing url and icon.
Yes, I am aware that some socials are special (weechat and email). In the latter case, I'd actually prefer to have email optional anyway..
Thanks!
Additional context
No response
The text was updated successfully, but these errors were encountered: