Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use master for the source code for personal/organization webpages #344

Merged
merged 1 commit into from
Jul 17, 2021

Conversation

neerajgangwar
Copy link
Contributor

@neerajgangwar neerajgangwar commented Jul 9, 2021

This PR is for #342 and makes the following changes:

  1. Always push the generated website code to gh-pages.
  2. Update the documentation for the personal/organization webpages.

@alshedivat
Copy link
Owner

Thank you for the PR! I'm 100% in favor of simplifying deployment.

Can you please somehow confirm that deploying user and organization pages to gh-pages actually works? A while back, it used to be the case that user and organization pages had to be deployed to master. Did something change recently?

@neerajgangwar
Copy link
Contributor Author

@alshedivat Yes, even I remember this restriction. There is an option to configure a publishing source:

https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#choosing-a-publishing-source

I am not sure if this was always there or recently introduced. I have set up my page using the same method - https://github.com/neerajgangwar/neerajgangwar.github.io

@alshedivat alshedivat merged commit 4d5f2dc into alshedivat:master Jul 17, 2021
github-actions bot added a commit that referenced this pull request Jul 17, 2021
…ate the document (#344)

Co-authored-by: Neeraj Gangwar <neeraj.gangwar@myntra.com> [ci skip]
@neerajgangwar neerajgangwar deleted the issue-342 branch July 18, 2021 06:52
LoryPack pushed a commit to LoryPack/lorypack.github.io that referenced this pull request Aug 17, 2021
…ate the document (alshedivat#344)

Co-authored-by: Neeraj Gangwar <neeraj.gangwar@myntra.com>
markwang0 pushed a commit to markwang0/old_markwang0.github.io that referenced this pull request Jan 8, 2022
…ate the document (alshedivat#344)

Co-authored-by: Neeraj Gangwar <neeraj.gangwar@myntra.com>
cverluiseQB pushed a commit to cverluise/cverluise.github.io that referenced this pull request Jan 16, 2023
…ate the document (alshedivat#344)

Co-authored-by: Neeraj Gangwar <neeraj.gangwar@myntra.com>
pecey pushed a commit to pecey/pecey.github.io that referenced this pull request Jan 27, 2023
…ate the document (alshedivat#344)

Co-authored-by: Neeraj Gangwar <neeraj.gangwar@myntra.com>
antchristou pushed a commit to antchristou/antchristou.github.io that referenced this pull request Nov 20, 2023
…ate the document (alshedivat#344)

Co-authored-by: Neeraj Gangwar <neeraj.gangwar@myntra.com>
siantonelli pushed a commit to siantonelli/siantonelli.github.io that referenced this pull request Oct 26, 2024
…ate the document (alshedivat#344)

Co-authored-by: Neeraj Gangwar <neeraj.gangwar@myntra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants