Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix distill dark citation #516

Closed
wants to merge 1 commit into from
Closed

Fix distill dark citation #516

wants to merge 1 commit into from

Conversation

rohandebsarkar
Copy link
Collaborator

Applies a minor fix for better readability of distill post citations in dark theme.

@alshedivat alshedivat self-requested a review December 31, 2021 15:32
Copy link
Owner

@alshedivat alshedivat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this enhancement!

I would strongly prefer not to edit template.v2.js directly (treat it as an imported library). instead, I'd suggest overriding anything distill-related using either via _sass/_distill.scss or (for styles that distill loads dynamically) use assets/js/distillpub/overrides.js.

@alshedivat
Copy link
Owner

alshedivat commented Dec 31, 2021

also, most of the issues with distill dark mode have been fixed in #299. looks like something got broken in one of the subsequent PRs. just fixed the issue in #517. lmk if that solves the issue.

@rohandebsarkar
Copy link
Collaborator Author

Yes, #516 fixes it. Thank you.

@rohandebsarkar rohandebsarkar deleted the fix-distill-dark-citation branch January 5, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants