issue URL not inserted if issue title contains regex characters #226
Comments
|
@alstr, the solution is already implemented. |
rgalonso
added a commit
to rgalonso/todo-to-issue-action
that referenced
this issue
Nov 9, 2024
There are issues currently where the wrong text may be inserted in place of the issue URL. (See github.com/alstr/todo-to-issue-action issues alstr#224 , alstr#225, and alstr#226, for example.) When such a situation is detected, the offending line is now NOT inserted and instead a warning message is printed out. This doesn't completely resolve those issues, but mitigates against them and other similar issues which may arise in the future.
rgalonso
added a commit
to rgalonso/todo-to-issue-action
that referenced
this issue
Nov 9, 2024
If regex characters are part of the title (for example, parentheses), then this breaks the ability to find the comment line when trying to insert the issue URL. This commit escapes the title to fix this problem. Closes github.com/alstr#226
Merged
|
Another one I think is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the TODO comment's first line (i.e. what will become the issue title) contains any regex characters (for example
TODO: fix this (after first fixing issue #34), then the issue URL will not get properly inserted. (The line containing the TODO will just be repeated, as explained by #224/#225.)This is happening because the
re.sub()call which modifies the inserted line is not escaping the title.The text was updated successfully, but these errors were encountered: