You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the identifier contains regex characters, the issue is not properly created. For example, using identifier [TODO] with a comment like [TODO]: implement the widget causes problems. In version v5.1.1 (and earlier), this leads to an issue not being created. In v5.1.2, this leads to an issue with title ]: implement the widget being created.
In v5.1.1, this is due to the parser not escaping the identifier when performing the regex search for the identifier and title. In V5.1.2, it's due to the word boundary marker \b not properly handling [ and ] characters. The general solution going forward needs to be that
the identifier is escaped, and
a slightly different pattern which doesn't rely on \b is used to find the identifier word boundary
The text was updated successfully, but these errors were encountered:
rgalonso
added a commit
to rgalonso/todo-to-issue-action
that referenced
this issue
Nov 12, 2024
Provides a test for and the solution to GitHub
issue alstr#242. Namely, an identifier which contains
regex characters (e.g. "[TODO]") is properly
handled by having the parser look for literal
"[" and "]" characters rather than treating those
characters as part of a regex pattern. The word
boundary regex pattern '\b' does NOT properly
handle this, so a slightly different pattern is
used to identify the boundary.
If the identifier contains regex characters, the issue is not properly created. For example, using identifier
[TODO]
with a comment like[TODO]: implement the widget
causes problems. In version v5.1.1 (and earlier), this leads to an issue not being created. In v5.1.2, this leads to an issue with title]: implement the widget
being created.In v5.1.1, this is due to the parser not escaping the identifier when performing the regex search for the identifier and title. In V5.1.2, it's due to the word boundary marker
\b
not properly handling[
and]
characters. The general solution going forward needs to be that\b
is used to find the identifier word boundaryThe text was updated successfully, but these errors were encountered: