Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for VBA Component Files #163

Merged
merged 9 commits into from
Sep 25, 2024
Merged

Add Support for VBA Component Files #163

merged 9 commits into from
Sep 25, 2024

Conversation

cyadehn
Copy link
Contributor

@cyadehn cyadehn commented Aug 28, 2023

Adds syntax for Visual Basic for Applications files exported from Office VBIDE

@alstr
Copy link
Owner

alstr commented Sep 7, 2023

Thanks very much for the contribution.

I noticed a few issues when running the rests.

  • Typo with assertEqual - I've fixed that.
  • The tests are based on the ace_mode, not the language name, so I've removed the VBA tests and subsumed them under the Org ones with ace_mode: text.

That fixed the tests failing.

Current problems though:

  • .sht files aren't recognised by languages.yml, and the test is only finding 2 of the 4 TODOs you added (hence why I updated the tests to look for 6 not 8).
  • Given that these extensions are associated with multiple languages it is potentially going to be problematic linking the extension to a particular programming comment syntax unless it's the same for all of them. E.g. search for ".cls" in languages.yml and you get Apex, ObjectScript, VBA and others. I want to figure out a way around it, just not sure this very second.

@alstr alstr merged commit 2e61693 into alstr:master Sep 25, 2024
1 check passed
@alstr
Copy link
Owner

alstr commented Sep 25, 2024

Merged but with the caveats mentioned previously. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants