fix: handle different line endings #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the build failed. I'll investigate and put this back in the ready state when it's resolved. |
Fix a regression that was accidentally introduced with v5.1.2 which could cause an issue URL to not be successfully added to the source file when dealing with a CRLF (Windows-style line endings) file on Linux. Partially addresses GitHub issue alstr#245
Regardless of the OS on which the app is running, respect the original line endings of the file when writing back the issue URL. In the case of a mixed line-ending file (e.g. both Windows-style CRLF and Unix-style LF), the issue URL comment line will use the line ending style of the TODO comment line above it. Partially addresses GitHub issue alstr#245
Ensure alignment of issue URL line is correct even when the TODO line had any number of tab characters prior to the issue title Addresses remaining sub-issues of and closes GitHub issue alstr#245
rgalonso
force-pushed
the
fix/handle-different-line-endings
branch
from
09d3fe4 to
6f69995
Compare
|
@alstr, ready for your review |
|
Thanks! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #245