Conversation
|
Is there anything holding th is up from being merged @ydnar? |
ydnar
left a comment
There was a problem hiding this comment.
Thanks! Can you add an end to end test, ensuring this is tested in dev and CI?
I can do this, but to test that we'd need to add |
|
Given that 100% of the users of this tool will have that installed, I think we can assume its presence. I don't think we need to bump Go version to 1.24 to achieve this. |
To use The application itself can be built on older versions as it's just running the command, but the go module that it runs in when tool is enabled must be 1.24 or newer. The only other option would be to make a separate module just for testing that only runs on go1.24 and not earlier versions but that'd likely make sense as an entirely separate workflow which seems a bit overkill. |
|
Thoughts on my last comment @ydnar? I wasn't able to find a way to make a test work without the module being go1.24 or newer as that's when the go tool pattern functionality was introduced. |
This implements the feature requested in #181