Skip to content

Remove use of HashMap #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

celsworth
Copy link

Description

This may be a matter of preference, but I'd like to know what you think!

Removing HashMap here should make this faster and avoids the need to clone the map and add to the clone all the time by calling query more than once (this just appends to the query).

Storing the tuples in the format that query expects to be called with means we just construct them once at build time then pass the same thing by reference forever. Should be super-quick :)

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy cargo clippy --all-targets --all-features -- -D warnings
  • Updated README.md using cargo readme -r influxdb -t ../README.tpl > README.md
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

@celsworth celsworth force-pushed the remove-hashmap branch 2 times, most recently from 6986730 to fac4c0a Compare June 15, 2021 17:43
@celsworth
Copy link
Author

Hmm this doesn't work yet, let me get back to you ;)

@celsworth celsworth closed this Jun 15, 2021
@celsworth celsworth mentioned this pull request Jun 15, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant