Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OrdinalEncoder component #3736

Merged
merged 20 commits into from
Oct 6, 2022
Merged

Add OrdinalEncoder component #3736

merged 20 commits into from
Oct 6, 2022

Commits on Oct 6, 2022

  1. Initial implementation of ordinal encoder

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    220bdd7 View commit details
    Browse the repository at this point in the history

  2. Add more tests and fix encoder behavior

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    833a08d View commit details
    Browse the repository at this point in the history

  3. More tests and use ltype order as source of truth

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    fec0cb0 View commit details
    Browse the repository at this point in the history

  4. add more tests and make sure categories order matches ordinal ltype's

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    4d3bd08 View commit details
    Browse the repository at this point in the history

  5. Add remaining tests

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    1aa2e97 View commit details
    Browse the repository at this point in the history

  6. record which tests weren't converted

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    becaf89 View commit details
    Browse the repository at this point in the history

  7. Start cleaning up and covering edge cases

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    8db0905 View commit details
    Browse the repository at this point in the history

  8. Finish filling out tests and remove unnecessary arrow comments

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    c9aa184 View commit details
    Browse the repository at this point in the history

  9. clean up

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    30c2d4c View commit details
    Browse the repository at this point in the history

  10. lint fix and fill out docstrings

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    036e074 View commit details
    Browse the repository at this point in the history

  11. Add release note

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    12af4d2 View commit details
    Browse the repository at this point in the history

  12. Fix broken component tests

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    a4d9971 View commit details
    Browse the repository at this point in the history

  13. Remove remaining arrow comments

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    85a5335 View commit details
    Browse the repository at this point in the history

  14. Remove top_n parameter

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    bb60111 View commit details
    Browse the repository at this point in the history

  15. Shorter MR comments

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    38a8e01 View commit details
    Browse the repository at this point in the history

  16. split errors in two

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    4d81962 View commit details
    Browse the repository at this point in the history

  17. Refactor transform to avoid unnecessary copying

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    dd9f05b View commit details
    Browse the repository at this point in the history

  18. MR comments

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    e82b13a View commit details
    Browse the repository at this point in the history

  19. Make categories arg a dict

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    94ca85c View commit details
    Browse the repository at this point in the history

  20. remove commented code

    Tamar Grey committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    ee81b32 View commit details
    Browse the repository at this point in the history