Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BytesIO support to PipelineBase.load() #4179

Merged
merged 6 commits into from
May 9, 2023

Conversation

cp2boston
Copy link
Contributor

@cp2boston cp2boston commented May 8, 2023

Pull Request Description

Added support for BytesIO input to PipelineBase.load(), primarily to support VFS

Fixes #4178

@CLAassistant
Copy link

CLAassistant commented May 8, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #4179 (2469770) into main (ee540f1) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4179     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        349     349             
  Lines      37797   37809     +12     
=======================================
+ Hits       37680   37692     +12     
  Misses       117     117             
Impacted Files Coverage Δ
evalml/pipelines/pipeline_base.py 98.5% <100.0%> (+0.1%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 99.9% <100.0%> (+0.1%) ⬆️

@cp2boston cp2boston changed the title OSSEVALML-579 Added BytesIO support to PipelineBase.load() Added BytesIO support to PipelineBase.load() May 8, 2023
@cp2boston cp2boston requested a review from chukarsten May 8, 2023 19:11
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit but otherwise LGTM!

evalml/tests/pipeline_tests/test_pipelines.py Show resolved Hide resolved
@chukarsten chukarsten merged commit b530abd into main May 9, 2023
@chukarsten chukarsten deleted the OSSEVALML-579_PipelineBase_load-BytesIO branch May 9, 2023 16:46
@chukarsten chukarsten mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PipelineBase.load() to accept both a path and a file-like object
4 participants