Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perfect id column match with text possible #4203

Merged
merged 18 commits into from
Jun 15, 2023
Merged

perfect id column match with text possible #4203

merged 18 commits into from
Jun 15, 2023

Conversation

simha104
Copy link
Contributor

@simha104 simha104 commented Jun 7, 2023 •
edited
Loading

Pull Request Description

Perfect id column match with text possible
Resolves #4206

@codecov
Copy link

codecov bot commented Jun 7, 2023 •
edited
Loading

Codecov Report

Merging #4203 (5a4a935) into main (6c5e9c8) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4203     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        349     349             
  Lines      38229   38236      +7     
=======================================
+ Hits       38109   38116      +7     
  Misses       120     120
Impacted Files Coverage Δ
evalml/data_checks/id_columns_data_check.py 100.0% <100.0%> (ø)
evalml/tests/conftest.py 98.3% <100.0%> (+0.1%) ⬆️
...ts/data_checks_tests/test_id_columns_data_check.py 100.0% <100.0%> (ø)

@simha104 simha104 changed the title perfect id column match with uuid possibel perfect id column match with uuid possible Jun 8, 2023
@simha104 simha104 changed the title perfect id column match with uuid possible perfect id column match with text possible Jun 8, 2023
bchen1116
bchen1116 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left one comment for clarity

@ParthivNaresh ParthivNaresh self-requested a review June 14, 2023 21:27
ParthivNaresh
ParthivNaresh approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@simha104 simha104 merged commit e75be9d into main Jun 15, 2023
@simha104 simha104 deleted the uuid_primary_key branch June 15, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParthivNaresh ParthivNaresh ParthivNaresh approved these changes

@bchen1116 bchen1116 bchen1116 approved these changes

Assignees

@simha104 simha104

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text columns should be able to to be identified as a perfect match for an ID column
3 participants
@simha104 @bchen1116 @ParthivNaresh