Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiseries support to graph_prediction_vs_actual_over_time #4284
Add multiseries support to graph_prediction_vs_actual_over_time #4284
Changes from 11 commits
d15f9ae
3bfa655
f46f979
0f62ffb
825dc1d
b321128
224a34c
460c4cf
9c770d3
03e0e24
7865bee
1f7762c
8ebf3b0
2bd6b1c
92e1b64
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 378 in evalml/model_understanding/visualizations.py
Codecov / codecov/patch
evalml/model_understanding/visualizations.py#L377-L378
Check warning on line 387 in evalml/model_understanding/visualizations.py
Codecov / codecov/patch
evalml/model_understanding/visualizations.py#L387
Check warning on line 426 in evalml/model_understanding/visualizations.py
Codecov / codecov/patch
evalml/model_understanding/visualizations.py#L426
Check warning on line 431 in evalml/model_understanding/visualizations.py
Codecov / codecov/patch
evalml/model_understanding/visualizations.py#L431
Check warning on line 450 in evalml/model_understanding/visualizations.py
Codecov / codecov/patch
evalml/model_understanding/visualizations.py#L449-L450
Check warning on line 453 in evalml/model_understanding/visualizations.py
Codecov / codecov/patch
evalml/model_understanding/visualizations.py#L453
Check warning on line 460 in evalml/model_understanding/visualizations.py
Codecov / codecov/patch
evalml/model_understanding/visualizations.py#L458-L460
Check warning on line 470 in evalml/model_understanding/visualizations.py
Codecov / codecov/patch
evalml/model_understanding/visualizations.py#L470
Check warning on line 483 in evalml/model_understanding/visualizations.py
Codecov / codecov/patch
evalml/model_understanding/visualizations.py#L480-L483
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any autosizing we can take advantage of? Also not sure if we need the single_series case: can it just match what we already had before for time series?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data["target"]
whereas for single series I want to take it fromcurr_df["target"]
wherecurr_df = data[data["series_id"] == single_series]
if
statements and such so it made more sense to me to have it included with the multiseries case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool - thanks for the explanation. Works for me!
Check warning on line 489 in evalml/model_understanding/visualizations.py
Codecov / codecov/patch
evalml/model_understanding/visualizations.py#L489
Check warning on line 494 in evalml/model_understanding/visualizations.py
Codecov / codecov/patch
evalml/model_understanding/visualizations.py#L494
Check warning on line 35 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L35
Check warning on line 42 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L40-L42
Check warning on line 54 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L52-L54
Check warning on line 385 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L385
Check warning on line 391 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L390-L391
Check warning on line 397 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L397
Check warning on line 402 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L401-L402
Check warning on line 411 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L410-L411
Check warning on line 475 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L475
Check warning on line 482 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L481-L482
Check warning on line 488 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L488
Check warning on line 493 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L492-L493
Check warning on line 503 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L502-L503
Check warning on line 508 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L505-L508
Check warning on line 513 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L510-L513
Check warning on line 518 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L515-L518
Check warning on line 521 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L521
Check warning on line 528 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L527-L528
Check warning on line 534 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L534
Check warning on line 539 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L538-L539
Check warning on line 547 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L547
Check warning on line 552 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L549-L552
Check warning on line 555 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L555
Check warning on line 561 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L557-L561
Check warning on line 564 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L563-L564
Check warning on line 567 in evalml/tests/model_understanding_tests/test_visualizations.py
Codecov / codecov/patch
evalml/tests/model_understanding_tests/test_visualizations.py#L566-L567