-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated excluded_model_families
data type
#4287
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4287 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 355 355
Lines 39154 39155 +1
=======================================
+ Hits 39034 39035 +1
Misses 120 120
☔ View full report in Codecov by Sentry. |
@@ -5356,7 +5356,7 @@ def test_excluded_model_families( | |||
y_train=y, | |||
problem_type=ProblemTypes.BINARY, | |||
automl_algorithm=automl_algorithm, | |||
excluded_model_families=[ModelFamily.RANDOM_FOREST], | |||
excluded_model_families=[ModelFamily.RANDOM_FOREST, "linear_model"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also assert than any linear models are not created as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Resolves #4259
Updated
excluded_model_families
to allow bothstr
andModelFamily
data types and updated corresponding documentation.