Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated excluded_model_families data type #4287

Merged
merged 9 commits into from
Aug 29, 2023

Conversation

remyogasawara
Copy link
Collaborator

@remyogasawara remyogasawara commented Aug 24, 2023

Resolves #4259

Updated excluded_model_families to allow both str and ModelFamily data types and updated corresponding documentation.

@remyogasawara remyogasawara self-assigned this Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.0% and project coverage change: +0.1% 🎉

Comparison is base (ecbb2e4) 99.7% compared to head (2ccf674) 99.7%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4287     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        355     355             
  Lines      39154   39155      +1     
=======================================
+ Hits       39034   39035      +1     
  Misses       120     120             
Files Changed Coverage Δ
...valml/automl/automl_algorithm/default_algorithm.py 99.7% <ø> (ø)
...lml/automl/automl_algorithm/iterative_algorithm.py 97.5% <ø> (ø)
evalml/pipelines/components/utils.py 96.8% <ø> (ø)
evalml/automl/automl_search.py 99.8% <100.0%> (ø)
evalml/tests/automl_tests/test_automl.py 99.5% <100.0%> (+0.1%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -5356,7 +5356,7 @@ def test_excluded_model_families(
y_train=y,
problem_type=ProblemTypes.BINARY,
automl_algorithm=automl_algorithm,
excluded_model_families=[ModelFamily.RANDOM_FOREST],
excluded_model_families=[ModelFamily.RANDOM_FOREST, "linear_model"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also assert than any linear models are not created as well.

Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@remyogasawara remyogasawara merged commit 032db03 into main Aug 29, 2023
22 checks passed
@remyogasawara remyogasawara deleted the 4259_update_exluded_model_families_doc branch August 29, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"allowed families" argument ignores LightGBM
3 participants