-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend TimeSeriesImputer to handle multiple series #4291
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c8addb4
time series imputer multiseries support
MichaelFu512 eb96bca
Fixed interpolate error
MichaelFu512 f4d532d
testing
MichaelFu512 c1dda0f
Merge branch 'main' into TML-8374
MichaelFu512 278d953
updated release notes
MichaelFu512 021dfec
added new test
MichaelFu512 c1acd19
fixed comment and reworked downcast y
MichaelFu512 24d5e05
removed stray comment
MichaelFu512 d5b4652
codecov
MichaelFu512 96f43a1
removed redundant code
MichaelFu512 a12d92d
updated comments
MichaelFu512 f99e3d1
Merge branch 'main' into TML-8374
MichaelFu512 3938001
removed redundant code
MichaelFu512 b3c8392
tests
MichaelFu512 6dec926
Merge branch 'TML-8374' of github.com:alteryx/evalml into TML-8374
MichaelFu512 d03ad74
Merge branch 'main' into TML-8374
MichaelFu512 3f8118a
added some nans
MichaelFu512 5435b19
maybe codecov will pass now
MichaelFu512 41c277e
fix test
MichaelFu512 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would benefit from another test (parametrized here) where only some of the columns are NaN, but not all of them!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ Sorry, should have clarified 😅 I meant a test where some of the columns are all NaN, so we drop some columns and impute or pass through others!