Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release.md guide #4346

Merged
merged 9 commits into from
Oct 25, 2023
Merged

Update release.md guide #4346

merged 9 commits into from
Oct 25, 2023

Conversation

MichaelFu512
Copy link
Contributor

@MichaelFu512 MichaelFu512 commented Oct 16, 2023

Pull Request Description

Closes #4347

Added section on troubleshooting github action
Fixed some formatting and words


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

Added section on troubleshooting github action
Fixed some formatting and words
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f81a991) 99.7% compared to head (ee67836) 99.7%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4346   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        357     357           
  Lines      39869   39869           
=====================================
  Hits       39749   39749           
  Misses       120     120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some non-blocking nitpicks, thanks!

docs/source/release_notes.rst Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
@MichaelFu512 MichaelFu512 merged commit 7713636 into main Oct 25, 2023
25 checks passed
@MichaelFu512 MichaelFu512 deleted the update-release-guide branch October 25, 2023 16:32
@MichaelFu512 MichaelFu512 mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release guide
3 participants