Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove things related to vowpalwabbit #4427

Merged
merged 12 commits into from
May 21, 2024
Merged

Remove things related to vowpalwabbit #4427

merged 12 commits into from
May 21, 2024

Conversation

MichaelFu512
Copy link
Contributor

Pull Request Description

Closes #4419


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.7%. Comparing base (fb26ef2) to head (c74ce93).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4427     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        357     352      -5     
  Lines      39973   39805    -168     
=======================================
- Hits       39849   39682    -167     
+ Misses       124     123      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelFu512 MichaelFu512 changed the title remove things related to vowpalwabbit Remove things related to vowpalwabbit May 20, 2024
@@ -1018,9 +963,9 @@ def test_components_can_be_used_for_partial_dependence_fast_mode():
# Expected number is hardcoded so that this test will fail when new components are added
# It should be len(all_native_components) - num_invalid_for_pd_fast_mode
if ProphetRegressor not in all_native_components:
expected_num_valid_for_pd_fast_mode = 65
expected_num_valid_for_pd_fast_mode = 62
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codecov says this line isn't covered by test (and the check for codecov fails as well) if I don't include line 947-948.

@MichaelFu512 MichaelFu512 marked this pull request as ready for review May 20, 2024 20:10
docs/source/release_notes.rst Outdated Show resolved Hide resolved
@MichaelFu512 MichaelFu512 merged commit 80ccb4d into main May 21, 2024
27 checks passed
@MichaelFu512 MichaelFu512 deleted the remove_vowpalwabbit branch May 21, 2024 20:22
This was referenced Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove vowpalwabbit until it supports python 3.11
3 participants