Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for min dependency checker #2709

Merged
merged 2 commits into from
May 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests_with_latest_deps.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Install featuretools with test requirements
run: |
python -m pip install -e unpacked_sdist/
python -m pip install -e unpacked_sdist/[test]
python -m pip install -e unpacked_sdist/[test,dask]
- if: ${{ matrix.python_version == 3.9 }}
name: Generate coverage args
run: echo "coverage_args=--cov=featuretools --cov-config=../pyproject.toml --cov-report=xml:../coverage.xml" >> $GITHUB_ENV
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
conda config --add channels conda-forge
conda install -q -y -c conda-forge python-graphviz graphviz
python -m pip install --upgrade pip
python -m pip install .[test]
python -m pip install .[test,dask]
- name: Run unit tests
run: |
. $env:USERPROFILE\Miniconda3\shell\condabin\conda-hook.ps1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests_with_woodwork_main_branch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
sudo apt update && sudo apt install -y graphviz
- name: Install Woodwork & Featuretools - test requirements
run: |
python -m pip install -e unpacked_sdist/[test]
python -m pip install -e unpacked_sdist/[test,dask]
python -m pip uninstall -y woodwork
python -m pip install https://github.com/alteryx/woodwork/archive/main.zip
- name: Log test run info
Expand Down
1 change: 1 addition & 0 deletions docs/source/release_notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Future Release
* Documentation Changes
* Testing Changes
* Fix serialization test to work with pytest 8.1.1 (:pr:`2694`)
* Update to allow minimum dependency checker to run properly (:pr:`2709`)

Thanks to the following people for contributing to this release:
:user:`thehomebrewnerd`
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ test = [
"smart-open >= 5.0.0",
"urllib3 >= 1.26.18",
"pytest-timeout >= 2.1.0",
"featuretools[dask]"
]
dask = [
"dask[dataframe] >= 2023.2.0",
Expand Down
Loading