Fix SLP offsets for ECB data when using Slippi FM 3.0.3. #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slippi FM version: 3.0.3 (current at time of pull request)
Platform: Windows 10
When I use
smashbot_state.ecb.X.X
, I am getting incorrect values. This pull request fixes the values.Reference: ECB data for frame 1 of Ganondorf's Dark Dive (action
SWORD_DANCE_3_LOW
).Note 1: these values changed slightly depending on how far away from the center of the stage I was, probably due to rounding differences at higher values. I decided for the before/after to zero out the rounding differences.
Note 2: I multiplied all x-values by -1, including top and bottom even though those are always zero. When Python 3 multiplies the floating point 0.0 by -1, it returns -0.0. Feel free to suggest/implement a fix for this if would cause issues.
Before fix:
After fix: