Skip to content

Commit

Permalink
cmake msvc: remove quote for /wd4100
Browse files Browse the repository at this point in the history
* Command line error D8021 : invalid numeric argument
  • Loading branch information
luncliff authored and durswd committed Nov 3, 2023
1 parent 5b5b767 commit 1b6b59b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ else()
endif()

if(MSVC)
target_compile_options(LLGI PRIVATE /W4 /WX /wd"4100")
target_compile_options(LLGI PRIVATE /W4 /WX /wd4100)
else()
target_compile_options(LLGI PRIVATE -Wall -Werror)
endif()
Expand Down
2 changes: 1 addition & 1 deletion src_test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ file(COPY ${CMAKE_CURRENT_SOURCE_DIR}/Shaders
clang_format(LLGI_Test)

if(MSVC)
target_compile_options(LLGI_Test PRIVATE /W4 /WX /wd"4100")
target_compile_options(LLGI_Test PRIVATE /W4 /WX /wd4100)
else()
target_compile_options(LLGI_Test PRIVATE -Wall -Werror)
endif()
2 changes: 1 addition & 1 deletion tools/ShaderTranspiler/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ target_include_directories(ShaderTranspiler PUBLIC ../ShaderTranspilerCore)
target_link_libraries(ShaderTranspiler PUBLIC ShaderTranspilerCore)

if(MSVC)
target_compile_options(ShaderTranspiler PRIVATE /W4 /WX /wd"4100")
target_compile_options(ShaderTranspiler PRIVATE /W4 /WX /wd4100)
else()
target_compile_options(ShaderTranspiler PRIVATE -Wall -Werror)
endif()
2 changes: 1 addition & 1 deletion tools/ShaderTranspilerCore/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ if(USE_THIRDPARTY_DIRECTORY)
endif()

if(MSVC)
target_compile_options(ShaderTranspilerCore PRIVATE /W4 /WX /wd"4100")
target_compile_options(ShaderTranspilerCore PRIVATE /W4 /WX /wd4100)
else()
target_compile_options(ShaderTranspilerCore PRIVATE -Wall -Werror)
endif()
Expand Down

0 comments on commit 1b6b59b

Please sign in to comment.