Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shim over lua differences #30

Merged
merged 13 commits into from
Apr 9, 2023
Merged

shim over lua differences #30

merged 13 commits into from
Apr 9, 2023

Conversation

zig-for
Copy link
Contributor

@zig-for zig-for commented Apr 8, 2023

Shim over differences between lua 5.1 and 5.4.

See TASEmulators/BizHawk#3616 for source issues

  • Allows connector script to select proper luasocket version between 5.1 and 5.4, depending on lua environment version
    • There's weirdness in Bizhawk 2.9 that requires absolute paths to modules, unfortunately
  • Unifies folder structure between OSes and between dev and release versions - now always Connector.lua at the top level, with folders for each arch as siblings. In each arch folder, shared libraries of the form socket-{OS}-{LUA_MAJOR}-{LUA_MINOR}.{EXT} live.
    • This allows consistent testing between dev/release, as well as one less step to screw up when selecting the proper lua version

Tested on:

  • Win64 Bizhawk 2.8
  • Win64 Bizhawk 2.9
  • Linux Bizhawk
  • Snes9x

@zig-for zig-for marked this pull request as ready for review April 9, 2023 06:18
@zig-for zig-for changed the title WIP: shim over lua differences shim over lua differences Apr 9, 2023
lua/Connector.lua Outdated Show resolved Hide resolved
lua/Connector.lua Outdated Show resolved Hide resolved
lua/Connector.lua Outdated Show resolved Hide resolved
lua/Connector.lua Outdated Show resolved Hide resolved
@JamesDunne JamesDunne merged commit ada0594 into alttpo:main Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants