-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gRPCweb example #33
Conversation
lgtm! I'll run it locally first and merge if it looks good. thank you. |
This has been tidied up a bit and removed old dependencies. I've confirmed it runs on Windows, M1 Mac and Intel Mac. |
I like the new cleanups but I think you went one step too far with removing The original intention of this grpcweb example was to be a minimal working example of how to use grpc-web to talk to SNI directly from a web browser, which isn't normally possible with vanilla grpc. |
No worries. I got caught up in cleaning up that I forgot that this is an |
@JamesDunne This is ready for review again. I've used Next.js to make an example page that uses ![]() ![]() ![]() |
The
examples/grpcweb
folder currently only works with Windows. This PR updates a couple of things to address this:gen.sh
has been changed to be executable. This was done withchmod +x ./gen.sh
.gen.sh
is now runs cross-platform. This previously failed due to the path ofprotoc-gen-ts
having a hardcoded.cmd
at the end which does not exist for Linux/Mac users.package.json
file. Runningnpm run build
will do the same thing as./gen.sh
.I've also added a
README.md
to help get anyone looking to get started.