Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor read_chunk to eliminate possible compiler warning #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alugowski
Copy link
Owner

Previous code could cause a compiler warning with overly-pedantic settings: 'value' may be used uninitialized

Previous behavior was correct, only initialized values would be read. New version also has simpler logic.

Previous code could cause a compiler warning with overly-pedantic settings: 'value' may be used uninitialized

Previous behavior was correct, only initialized values would be read. New version also has simpler logic.
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b8e3403) 95.84% compared to head (96d99ea) 95.77%.

Files Patch % Lines
include/fast_matrix_market/read_body.hpp 92.68% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   95.84%   95.77%   -0.07%     
==========================================
  Files          22       22              
  Lines        1563     1561       -2     
  Branches      176      173       -3     
==========================================
- Hits         1498     1495       -3     
- Misses         65       66       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant