Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rangesLiElList is missing 'var =' which is bad practice (global varia… #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nerdess
Copy link

@nerdess nerdess commented May 21, 2024

changed

rangesLiElList = ...

to

var rangesLiElList = ...

because

  • the missing var is creating a global variable (polluting global namespace)
  • not working in strict mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant