Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace su with Puppet::Util::Execution.execute #106

Merged
merged 1 commit into from
Jan 14, 2015
Merged

replace su with Puppet::Util::Execution.execute #106

merged 1 commit into from
Jan 14, 2015

Conversation

igalic
Copy link
Contributor

@igalic igalic commented Oct 16, 2014

Puppet::Util::Execution should be slightly more future-safe and
platform independent than su.

this should fix #80, in a more reliable way than #97 does.

@igalic
replace su with Puppet::Util::Execution.execute
936bb21 
`Puppet::Util::Execution` should be slightly more future-safe and
platform independent than `su`.

this should fix #80, in a more reliable way than #97 does.
@bderickson
Copy link

+1

Much better than my pull request, I'll close it and reference yours. :)

@bderickson bderickson mentioned this pull request Oct 16, 2014
Closed
@drewr
Copy link

drewr commented Nov 19, 2014

👍 This fixes an issue with Vagrant as well. It doesn't do things as the root user (I believe it's all sudo via vagrant user), so su isn't really an option. Thanks @igalic!

@igalic
Copy link
Contributor Author

igalic commented Nov 19, 2014

cool

@lieutdan13 lieutdan13 mentioned this pull request Jan 14, 2015
Closed
alup added a commit that referenced this pull request Jan 14, 2015
@alup
Merge pull request #106 from igalic/p-u-e
1ca1324 
replace su with Puppet::Util::Execution.execute
@alup alup merged commit 1ca1324 into alup:master Jan 14, 2015
@alup
Copy link
Owner

alup commented Jan 14, 2015

@igalic thanx for the patch

@gotascii
Copy link

I'm using puppet 2.7.11 and after this patch, I now get the error: err: /Stage[main]/Environment::Ruby/Rbenv::Compile[1.9.3-p484-railsexpress]/Rbenv::Gem[rbenv::bundler ubuntu 1.9.3-p484-railsexpress]/Rbenvgem[ubuntu/1.9.3-p484-railsexpress/bundler/present]: Could not evaluate: undefined method 'execute' for Puppet::Util::Execution:Module. I'm still investigating, just thought I'd mention it here and see if anyone has any suggestions.

@igalic igalic deleted the p-u-e branch January 16, 2015 11:11
@igalic
Copy link
Contributor Author

igalic commented Jan 16, 2015

@gotascii, so Puppet::Util::Execution.execute is "new" in 3.x then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rbenv::Compile and Rbenv::Gem run every time
5 participants
@igalic @bderickson @drewr @alup @gotascii