Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes an issue where the git clone exec resource was being called everytime #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

logicminds
Copy link

For some reason when I used the rbenv::plugin, the creates parameter in this resource was not behaving correctly which caused errors when git clone is run. Essentially, git refuses to clone the repo when the destination already exists.

The fix in the pull request essentially does the same thing as creates but actually works.

Error: git clone git://github.com/jamis/rbenv-gemset.git /var/www/.rbenv/plugins/rbenv-gemset returned 128 instead of one of [0]

exec { "rbenv::plugin::checkout ${user} ${plugin_name}":
command => "git clone ${source} ${destination}",
user => $user,
group => $group,
creates => "$destination",
path => ['/usr/bin', '/usr/sbin'],
timeout => $timeout,
cwd => $home_path,
require => File["rbenv::plugins ${user}"],
}

@ktham
Copy link
Contributor

ktham commented May 22, 2013

I don't see why this would produce any different behavior as any other exec with that contain an creates parameter, how do you reproduce this? I used puppet 3.1.1 on ubuntu 12.04 lts with no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants