Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to setExtraHTTPHeaders #78

Closed
wants to merge 3 commits into from

Conversation

maxshuty
Copy link

@maxshuty maxshuty commented Aug 7, 2018

I have added the ability to send custom headers which will help a lot of folks to resolve issues passing along a token for auth or whatever other use case they may have.

An example usage of how this is to be used is:

    "setExtraHTTPHeaders": {
        "customHeader": "test"
    }

I'm a .NET developer by nature, but I needed this ability and I thought the community could benefit from it. Please let me know if there are any issues with this PR and I will update them.

@kimmobrunfeldt
Copy link
Member

I think this looks otherwise good but this location is still missing the headers parameter:

function getOptsFromQuery(query) {

@kimmobrunfeldt
Copy link
Member

kimmobrunfeldt commented May 14, 2019

Thanks for the contribution! This is a good suggestion, but I would rather have something like this implemented: #99. I don't have currently time into helping in that PR but I like the idea of having full control to the request. It opens up even easier ways to exploit this service to make requests to internal services etc, but that's what the API_KEY is for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants