fix(packets): 🐛 Do not bail on "wired" field not found; fix protocol break

[zmerp]

No description provided.

[The-personified-devil]

Not to break even more things, but that flags seems really useless for what it ends up doing, we could just set the protocol to tcp if we're trying to wired. And I think it means that if we have an older client it breaks the integrated adb forwarding (perhaps even in a really unpredictable way), which would otherwise work with a new streamer.

But I think we'd have to keep supplying the flag server-side because otherwise v20.12.0 clients would still trip up over it not being present, even if we just set the protocol to tcp directly.

[The-personified-devil]

Of course we could also just merge this and only change that with v21, but if that's indeed the only thing holding back compat of older clients with integrated forwarding, then it might be worth doing.

[zmerp]

we could just set the protocol to tcp if we're trying to wired

The flag was added exactly to avoid having the user change the settings. And yes, for v21 I plan to remove that field because I plan to have the client try both UDP and TCP at the same time

[The-personified-devil]

The flag was added exactly to avoid having the user change the settings.

Ofc, but can't we just detect if we're trying to do a wired mode connection in the server connection flow and set that accordingly?

We're currently doing

let is_wired = client_ip.is_loopback();

streaming_caps.is_wired = is_wired;

try_connect();

// client side
if is_wired (
conn_type = tcp
)

// server side
if is_wire (
conn_type = tcp
)

How would doing this not accomplish the same:

let is_wired = client_ip.is_loopback();

try_connect();

if is_wired (
settings.conn_type = tcp
)

[The-personified-devil]

The exact same place we're sending over the wired flag we're also sending over the session config. (See here).
There's no reason not to change it in the session config we're sending over instead.

[zmerp]

Not sure i understood you correctly but anyway yeah, the client could have checked if the session contained a client named "client.wired"

[zmerp]

But for now this fix should be enough. I will remove the flag in v21

[zmerp]

There's no reason not to change it in the session config we're sending over instead.

By standard, I don't want us to change the session copy we send to the client. Each setting that is inferred at runtime should be negotiated using the negotiation structs

[The-personified-devil]

Not that I agree, but should be good enough.