Skip to content

Commit

Permalink
Tests: remove setting empty options dictionary on WorldTestBase
Browse files Browse the repository at this point in the history
  • Loading branch information
alwaysintreble committed Jul 17, 2024
1 parent 925e02d commit 99b67e1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/bases.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def _get_items_partial(self, item_pool, missing_item):


class WorldTestBase(unittest.TestCase):
options: typing.Dict[str, typing.Any] = {}
options: typing.ClassVar[typing.Dict[str, typing.Any]]
"""Define options that should be used when setting up this TestBase."""
multiworld: MultiWorld
"""The constructed MultiWorld instance after setup."""
Expand Down Expand Up @@ -279,7 +279,7 @@ def assertBeatable(self, beatable: bool):
@property
def run_default_tests(self) -> bool:
"""Not possible or identical to the base test that's always being run already"""
return (self.options
return (hasattr(self, "options")
or self.setUp.__code__ is not WorldTestBase.setUp.__code__
or self.world_setup.__code__ is not WorldTestBase.world_setup.__code__)

Expand Down

0 comments on commit 99b67e1

Please sign in to comment.