Support react-native 0.60+ and bug fixes #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttkien
approved these changes
Oct 22, 2019
ttkien
reviewed
Oct 22, 2019
|
@alwx Please, merge. |
|
@thanhcuong1990 thanks for your contribution and sorry that it took me so much time to merge it :) |
namvoeh
reviewed
Jan 7, 2021
| @@ -153,7 +154,7 @@ - (CGFloat)initialZoomScaleWithMinScale { | |||
| if (ABS(boundsAR - imageAR) < 0.17) { | |||
| zoomScale = MAX(xScale, yScale); | |||
| // Ensure we don't zoom in or out too far, just in case | |||
| zoomScale = MIN(MAX(self.minimumZoomScale, zoomScale), self.maximumZoomScale); | |||
| zoomScale = MIN(MAX(minZoom, zoomScale), minZoom); | |||
There was a problem hiding this comment.
@thanhcuong1990 Given zoom scale range is [0.1, 3]
if the zoom scale is 2, MIN(MAX(minZoom, zoomScale), minZoom) returns 0.1
can you share the reason for this change?
|
@alwx Would you mind releasing on NPM? The latest release is 3 years old... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.