Global settings additions #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 9, 2015 14:07
|
@bvangennep Good addition! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two additions here related to the settings.
Added template settings to global settings
There were settings to set the template path per form, we also added these to global settings to be able to set this path globally so we can override the templates for all forms. Reason being we would like to hide the more technical options of a form with permissions so that our clients could use it without breaking too much.
Added getSettings and setSettings to plugin class
Added a getSettings and setSettings method to the plugin class so that it follows the standard plugin pattern somewhat more. We also use the getSettings and setSettings methods to migrate plugin settings between environments.