Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket_ProcessEDoc Request #127

Closed
FarahHourani opened this issue Nov 15, 2017 · 15 comments
Closed

Ticket_ProcessEDoc Request #127

FarahHourani opened this issue Nov 15, 2017 · 15 comments
Milestone

Comments

@FarahHourani
Copy link
Contributor

Hello
Can u provide me with some tips or the steps to create new Ticket_ProcessEDoc request?

Thanks.

@DerMika
Copy link
Collaborator

DerMika commented Nov 15, 2017

Certainly!

I've written some explanation on how to implement a new message here and here. You can also check an implementation of a message I've implemented recently, for example this commit.

Hopefully these comments shed some light into the internal workings of the library. Let me know if you need any help!

@DerMika
Copy link
Collaborator

DerMika commented Nov 15, 2017

I will add that the hardest part of implementing a message is:

  1. Generating all the classes needed for the XML request structure (not hard, just an annoyingly large amount of manual class creation)
  2. Figuring out how to create the easiest possible RequestOptions class and how to translate those options into the XML message that must be sent.

For the second part, this is really a matter of studying all the samples for that message on the Amadeus Extranet and implement from there.

@FarahHourani
Copy link
Contributor Author

Thank u so much for your answer and help.. Finally it's done now :D 💃

@DerMika
Copy link
Collaborator

DerMika commented Dec 10, 2017

I'm looking forward to the Pull Request! :)

@FarahHourani
Copy link
Contributor Author

The problem is that i didn't implement the response handler i'm handling the error from my side for now i thought it's easier.. but i after implement it i will create a pull request

@DerMika
Copy link
Collaborator

DerMika commented Dec 12, 2017

Luckily the response handler isn't that much work compared to the rest. I wouldn't mind doing that myself (rather than risk not having this message implemented ;) ).

@FarahHourani
Copy link
Contributor Author

I pushed my updates, if you want any fix tell me. #135

@DerMika
Copy link
Collaborator

DerMika commented Dec 13, 2017

Thanks a lot for your contribution!

Do you prefer that I ask you to add the missing items (Response handler, unittests, docs), or would you rather have me do it?

@FarahHourani
Copy link
Contributor Author

Most welcome, I guess these things are gonna take a lot of time from me since i have a lot of other priorities right now so i guess u doing them is so much better

@FarahHourani
Copy link
Contributor Author

Is it a hard part ?

@DerMika
Copy link
Collaborator

DerMika commented Dec 13, 2017

Not really, but I don't mind doing it.

@FarahHourani
Copy link
Contributor Author

Cool, for me i have to figure out how to them, maybe in another message i'll be able to do them.

@DerMika
Copy link
Collaborator

DerMika commented Dec 13, 2017

I will merge your PR tonight and then make the necessary fixes.

Thanks again for the contribution!

@FarahHourani
Copy link
Contributor Author

Okay, Thanks to u too 👍

@DerMika
Copy link
Collaborator

DerMika commented Dec 17, 2017

I've just merged #135, thanks again!

@DerMika DerMika closed this as completed Dec 17, 2017
@DerMika DerMika added this to the 1.6.0 milestone Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants