Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fare_MasterPricerTravelBoardSearch additional options #20

Closed
ratheepan opened this issue Sep 20, 2016 · 7 comments
Closed

Fare_MasterPricerTravelBoardSearch additional options #20

ratheepan opened this issue Sep 20, 2016 · 7 comments

Comments

@ratheepan
Copy link

ratheepan commented Sep 20, 2016

Hello Friend,
Thank you very much for amadeus library.
I am using this library for my Project. My client have some additional features on Flight search (Fare_MasterPricerTravelBoardSearch) i need some information on following scenario

  1. In round trip search, is it possible to different cabinclass (eg Departure - Economy class and arrival First class)
  2. How can i include Preferred airlines and Direct Flights Only option s in the request.
  3. Is it possible to have "My dates are flexible. [+/- 1 days]" search option
    Could you please kindly share some examples request for above option.

Thanks in Advance
S Ratheepan

@DerMika
Copy link
Collaborator

DerMika commented Sep 20, 2016

Hi,

Cabin class
In the documentation of the Fare_MasterPricerTraveLBoardSearch, it is mentioned that you cannot request different cabin classes for the departure and for the return itinerary of a trip.

You can select a requested cabin code for your MasterPricer recommendations, and optionally you can provide a cabin option:

  • Mandatory Cabin: This cabin class applies to the entire requested itinerary.
  • Recommended Cabin: Cabin defaulting, when applicable, for flights that do not have the requested cabin service available. Note, however, that at least one of flight on each requested segment must propose the requested cabin in order to be eligible.
  • Major Cabin option, the transaction replies with recommendations that are mostly flown in the requested cabin for each requested segment.

However, this library does not support the Cabin Option yet.

Preferred airlines & direct flights
Direct flights only is possible by providing the following option:

$options = new FareMasterPricerTbSearch([
    //other options omitted for clarity
    'requestedFlightOptions' => [
        FareMasterPricerTbSearch::FLIGHTTYPE_DIRECT
    ]
])

... But I went into the code just now and saw that the option actually isn't implemented.

The same goes for specifying preferred airlines:

$options = new FareMasterPricerTbSearch([
    //other options omitted for clarity
    'mandatoryAirlines' => ['DL', 'AA']
])

The option exists in my library, but it isn't implemented yet.

Flexible days +/- 1
This is also an option that is possible with Fare_MasterPricerTravelBoardSearch, but isn't implemented in the library yet.

I am putting all of these limitations on my to-do list, and they will be included in the next release.

@DerMika DerMika added this to the 1.0.1 milestone Sep 20, 2016
@DerMika
Copy link
Collaborator

DerMika commented Sep 21, 2016

With the commit mentioned above, it's now possible to do the things you requested - except requesting a different cabin code for different itineraries (as explained above).

Please see the docs for sample messages: https://github.com/amabnl/amadeus-ws-client/blob/master/docs/samples/masterpricertravelboard.rst

@fayax
Copy link

fayax commented Sep 22, 2016

I'm getting this error with the latest commit for MPTB

Amadeus\Client\Result Object ( [status] => ERR [messages] => Array ( [0] => Amadeus\Client\Result\NotOk Object ( [code] => 936 [text] => Invalid time option [level] => ) ) [response] => stdClass Object ( [errorMessage] => stdClass Object ( [applicationError] => stdClass Object ( [applicationErrorDetail] => stdClass Object ( [error] => 936 ) ) [errorMessageText] => stdClass Object ( [freeTextQualification] => stdClass Object ( [textSubjectQualifier] => 1 ) [description] => Invalid time option ) ) ) [responseXml] => 9361Invalid time option )

Is there any bug or something I need to change on my end for the latest commit?

@DerMika
Copy link
Collaborator

DerMika commented Sep 22, 2016

It should be backwards compatible, if I didn't make any mistakes at least. Can you give me the Request Options so I can investigate?

And if you have a logger logging the requests & responses, can you also give me the generated request message? (you should probably obscure things like passwords & usernames while doing that)

@DerMika DerMika reopened this Sep 22, 2016
@DerMika
Copy link
Collaborator

DerMika commented Sep 22, 2016

Ok, I just reproduced the error, I'm investigating.

DerMika added a commit that referenced this issue Sep 22, 2016
@DerMika
Copy link
Collaborator

DerMika commented Sep 22, 2016

And it should be fixed now. Can you run composer update and try again?

@fayax
Copy link

fayax commented Sep 22, 2016

Now it works perfectly. Thanks

@DerMika DerMika closed this as completed Sep 22, 2016
atomy pushed a commit to mlamm/amadeus-ws-client that referenced this issue Nov 26, 2018
…AN-542-service.amadeus-add-opcache-to-php to master

* commit 'bcff0d5bc24005475560657600820907e9683871':
  VAN-542 service.amadeus / add opcache to php image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants