Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATC Shopper flow support #39

Closed
bimusiek opened this issue Feb 14, 2017 · 12 comments
Closed

ATC Shopper flow support #39

bimusiek opened this issue Feb 14, 2017 · 12 comments
Milestone

Comments

@bimusiek
Copy link
Collaborator

Hey, any plans to support ATC flow?

There are few new endpoints required, the hardest one being Ticket_ATCShopperMasterPricerCalendar and Ticket_ATCShopperMasterPricerTravelBoard.

We are in process of getting access to the second round of Amadeus certification for ATC and I was wondering if you could help us with it. :)

@DerMika
Copy link
Collaborator

DerMika commented Feb 14, 2017

I had not yet thought of supporting the ATC flow, no.

About the MasterPricer messages you mention: it looks like you can re-use much of the logic built for Fare_MasterPricerTravelBoardSearch to implement those messages - except for the ticketChangeInfo node.

I can implement them, but do not expect them within a few weeks as I'm quite busy with other responsibilities at the moment. I can't really give you an estimated time right now.

What are the other messages you looking at implementing besides these two?

@bimusiek
Copy link
Collaborator Author

bimusiek commented Feb 14, 2017

We have also applied for LCC support, but I see most of the messages are already integrated (the ones around DocIssuance)

About ATC, here is the list that is required to build whole flow and not yet supported:

  • Ticket_CheckEligibility
  • Ticket_ATCShopperMasterPricerCalendar (probably similar to MPCalendar)
  • Ticket_ATCShopperMasterPricerTravelBoard (as you said, similar to MPTravelBoardSearch)
  • [optional] Air_RebookAirSegment (similar to Air_SellFromRecommendation and is optional, it can be achieved by PNR_Cancel + Air_SellFromRecommendation, just saves 1 request to Amadeus)
  • Ticket_RepricePNRWithBookingClass (probably similar to informative pricing)
  • Ticket_ReissueConfirmedPricing
  • [optional] FOP_CreateFormOfPayment (I am not sure about this one, looks like you can achieve the same with AddMultiElements...)
  • Ticket_CreateTSMFareElement

Thats theoretically everything required for ATC support.
I skipped Doc Issuance part for ATC, as we are not ticketing agent so we will put PNR on special queue to re-issue ticket.

@bimusiek
Copy link
Collaborator Author

@DerMika we decided to skip calendar for now, just to have some basic features working.
So just to start working on ATC, Ticket_CheckEligibility and Ticket_ATCShopperMasterPricerTravelBoard are enough.
I could probably start working on it beginning of next month, just my PHP skills are quite rusty and obviously my Amadeus knowledge on scale 1-10 is probably at around 2 now. 🤕

And later only Ticket_RepricePNRWithBookingClass Ticket_ReissueConfirmedPricing and Ticket_CreateTSMFareElement.

I would love to buy you a beer at one point for all the help you provided, for Amadeus newbies this lib is much more understandable than Amadeus docs. 🍺 If you would ever visit Berlin, just drop me a message for 🍻 (we have one of the best beer in the world 🙉 )

@DerMika
Copy link
Collaborator

DerMika commented Feb 21, 2017

I will reply to the rest of your post later, but did you just tell a Belgian guy that the best beer in the world is in Berlin? What an insult! :p

@bimusiek
Copy link
Collaborator Author

Haha, I always try to play safe, that's why one of the best 🇩🇪 🇧🇪

DerMika added a commit that referenced this issue Feb 24, 2017
@DerMika
Copy link
Collaborator

DerMika commented Feb 24, 2017

... I started with an easy message first ...

@DerMika DerMika added this to the 1.3.0 milestone Feb 24, 2017
@DerMika
Copy link
Collaborator

DerMika commented Feb 24, 2017

I've started with the Ticket_CheckEligibility message. No promises on when it'll be ready though!

DerMika added a commit that referenced this issue Mar 3, 2017
@DerMika
Copy link
Collaborator

DerMika commented Mar 3, 2017

2 more messages to go: Ticket_RepricePNRWithBookingClass and Ticket_ReissueConfirmedPricing.

@DerMika DerMika changed the title ATC Shopper ATC Shopper flow support Mar 3, 2017
@bimusiek
Copy link
Collaborator Author

bimusiek commented Mar 6, 2017

We were supposed to get access at 27th Feb, but as we expected it is taking much longer :( Thanks for your amazing work @DerMika ! I am in ave.

@bimusiek
Copy link
Collaborator Author

We will finally get access to ATC in few days so I hope next week I will be able to play with first endpoints :) Thanks for help again!

@DerMika
Copy link
Collaborator

DerMika commented Mar 16, 2017

Ok, great. I'm still implementing the repricing message, which is sadly a bit like the Fare_* pricing messages but not quite the same, which means I have more work than expected to implement it :(

@DerMika
Copy link
Collaborator

DerMika commented Mar 22, 2017

So, I've implemented the messages you requested. Enjoy!

If you encounter any issues, don't hesitate to re-open this case or open a new one.

I haven't implemented Ticket_ATCShopperMasterPricerCalendar or Air_RebookAirSegment for now. If you have a need for them, let me know.

@DerMika DerMika closed this as completed Mar 22, 2017
atomy pushed a commit to mlamm/amadeus-ws-client that referenced this issue Nov 26, 2018
…o master

* commit 'b577fca78e68e2de47c04c19c7b1772a53fffda0':
  VAN-765 search / business case configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants