Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding manual commission (FM) with PNR_AddMultiElements #45

Closed
fayax opened this issue Mar 3, 2017 · 10 comments
Closed

Adding manual commission (FM) with PNR_AddMultiElements #45

fayax opened this issue Mar 3, 2017 · 10 comments

Comments

@fayax
Copy link

fayax commented Mar 3, 2017

Hello,

How do I add FM with PNR_AddMultiElements to PNR?
I think it is already implemented. Any example will be appreciated.

Thanks

@DerMika
Copy link
Collaborator

DerMika commented Mar 3, 2017

Hi,

(Besides using the message FOP_CreateFormOfPayment) there are 2 samples to add an FP to the PNR with PNR_AddMultiElements here: https://github.com/amabnl/amadeus-ws-client/blob/master/docs/samples/pnr-create-modify.rst#form-of-payment-fp

They are an FP CASH and an FP CCsample. To know how to enter the element you need, I need to know exactly what you want to do. The title of your issue seems to be contradicting itself, because a Manual Commission entry is an FM element, not an FP element.

The library doesn't support FM elements just yet, but I can add it.

@fayax fayax changed the title Adding manual commission (FP) with PNR_AddMultiElements Adding manual commission (FM) with PNR_AddMultiElements Mar 3, 2017
@fayax
Copy link
Author

fayax commented Mar 3, 2017

Sorry, typo. I mean FM.
Appreciate if you can add support for FM.

@DerMika DerMika added this to the 1.3.0 milestone Mar 3, 2017
@DerMika
Copy link
Collaborator

DerMika commented Mar 3, 2017

Can you please check the functional docs of Fare_MasterPricerTravelBoardSearch and tell me if you need anything more beyond the sample given in 5.28 Operation: Manual Commission, or if it is good enough for you if I implement support for that sample?

@fayax
Copy link
Author

fayax commented Mar 3, 2017

I think that example is enough. Amadeus support provided me this sample code.

<dataElementsIndiv>
    <elementManagementData>
        <reference>
            <qualifier>OT</qualifier>
            <number>2</number>
        </reference>
        <segmentName>FM</segmentName>
    </elementManagementData>
    <commission>
        <passengerType>PAX</passengerType>
        <indicator>FM</indicator>
        <commissionInfo>
            <percentage>0</percentage>
        </commissionInfo>
    </commission>
</dataElementsIndiv>

@DerMika
Copy link
Collaborator

DerMika commented Mar 7, 2017

Support for FM elements is now added.

Check the docs for a sample: https://github.com/amabnl/amadeus-ws-client/blob/master/docs/samples/pnr-create-modify.rst#manual-commission-fm

Don't hesitate to reopen this issue if it's not working for you!

@DerMika DerMika closed this as completed Mar 7, 2017
@fayax
Copy link
Author

fayax commented Mar 7, 2017

Thanks for the quick implementation.
MPTBS is not working for me now.
I get this error message.

<Fare_MasterPricerTravelBoardSearchReply xmlns="http://xml.amadeus.com/FMPTBR_14_3_1A">
         <errorMessage>
            <applicationError>
               <applicationErrorDetail>
                  <error>118</error>
               </applicationErrorDetail>
            </applicationError>
            <errorMessageText>
               <freeTextQualification>
                  <textSubjectQualifier>3</textSubjectQualifier>
               </freeTextQualification>
               <description>Transaction unable to process : AVL (712 / 301)</description>
            </errorMessageText>
         </errorMessage>
      </Fare_MasterPricerTravelBoardSearchReply>

I'm not sure if it is related with the latest commit. I was at v1.1.1 and then upgraded to 1.2.1 with FM implementation. Kindly advice.

@DerMika
Copy link
Collaborator

DerMika commented Mar 7, 2017

I've just tested 1.2.1 with a few MasterPricer calls, and they work fine here. Perhaps a temporary issue?

So... I can't reproduce this with the information I have now. Can you open a separate issue with the MasterPricer call you're trying to perform so I can try to reproduce?

@fayax
Copy link
Author

fayax commented Mar 8, 2017

It seems that it is a temporary issue. Works fine now. Thank you!

@DerMika
Copy link
Collaborator

DerMika commented Mar 8, 2017

Also, FM element support is not included in 1.2.1, it will be in 1.3.0. you'll need to switch your composer to 'dev-master' to test it.

atomy pushed a commit to mlamm/amadeus-ws-client that referenced this issue Nov 26, 2018
…AN-829-add-luggage-information-on-flight to master

* commit 'c0fd68499d154cc7be18d2ba2a5d1ca21dd8931b':
  VAN-829 add luggage information on flight details in offer list (front & backend)
@AhmedAbdallahNouh
Copy link

@fayax PLAEASE can you help me with this : i having this response :

<s:Body>
<Fare_MasterPricerTravelBoardSearchReply xmlns="http://xml.amadeus.com/FMPTBR_18_1_1A">



978




1

Invalid option


</Fare_MasterPricerTravelBoardSearchReply>
</s:Body>

when im trying to search with business cabin class

<s:Body xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<Fare_MasterPricerTravelBoardSearch xmlns="http://xml.amadeus.com/FMPTBQ_18_1_1A">


1
PX


250
RC



ADT

1




FFAMILY1
80



NONCORP


Y






ET
RP
RU





1



NCE




AMS




250724



</Fare_MasterPricerTravelBoardSearch>
</s:Body>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants