Implemented attaching arrival date and time at Air_SellFromRecommendation #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I'd like you to leave the original sample as it was, and add a new sample with the arrival date incuded. The people reading the sample should be able to see from the samples that the Arrival Date is an optional parameter. |
|
Thanks! I apologize I didn't mention this before, but the same goes for the unittest: I'd like a separate test to test with the arrival date, but the original test should stay the same. |
|
Thanks a lot for your contribution!! |
|
Version 1.7.0 has just been released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though is not mandatory it may help with flights that are overnight.