Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSMs tattoos on DocIssuance_IssueCombined #178

Merged
merged 8 commits into from
Apr 11, 2018
Merged

Conversation

bimusiek
Copy link
Collaborator

:)

I have also added expiry date test for FOP_CreateForOfPayment v14 as I was thinking it was the problem with issue I have reported earlier.

# Conflicts:
#	CHANGELOG.md
#	docs/samples/masterpricertravelboard.rst
#	src/Amadeus/Client/RequestOptions/MpBaseOptions.php
#	src/Amadeus/Client/Struct/Fare/MasterPricer/NumberOfUnit.php
#	src/Amadeus/Client/Struct/Fare/MasterPricer/PricingTicketing.php
#	src/Amadeus/Client/Struct/Fare/MasterPricer/UnitNumberDetail.php
#	tests/Amadeus/Client/Struct/Fare/MasterPricerTravelBoardSearchTest.php
@coveralls
Copy link

coveralls commented Apr 11, 2018

Coverage Status

Coverage increased (+0.0002%) to 99.853% when pulling 21d3ec6 on whatsahoy:master into 5bbde43 on amabnl:master.

@DerMika
Copy link
Collaborator

DerMika commented Apr 11, 2018

Problem is that the conversion to XML only happens once the \SoapClient gets involved and parses the PHP object. I haven't figured out how to simulate that in unittests yet.

@DerMika DerMika changed the title TSMs tattoos on IssueCombined TSMs tattoos on DocIssuance_IssueCombined Apr 11, 2018
@DerMika
Copy link
Collaborator

DerMika commented Apr 11, 2018

Could you add a sample to the docs? I'm asking mainly because there is no relevant sample in the Amadeus Extranet functional docs for this feature.

@DerMika DerMika merged commit 1d411da into amabnl:master Apr 11, 2018
@DerMika
Copy link
Collaborator

DerMika commented Apr 11, 2018

Thanks for another contribution!

DerMika added a commit that referenced this pull request Apr 26, 2018
@DerMika DerMika added this to the 1.7.0 milestone May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants