Implementing PNR_Ignore #198
Conversation
|
Currently I am using $pnrContent = $this->client->pnrRetrieve(
new PnrRetrieveOptions([
'actionCode' => [
PnrCreatePnrOptions::ACTION_IGNORE
]])
);Just mentioning that it was possible before using different endpoint. |
|
My opinion is that it's better to have an own endpoint. I think it is confusing to ignore a pnr while calling pnrRetrieve |
|
I don't mind having this message implemented at all, but I agree with @bimusiek that if you need this functionality right now, the library already supports ignoring PNR's through PNR_Retrieve. So, I don't mind merging your pull request, but you'll have to undo most of the style changes in the |
|
My answer was related to your statement I am not saying it is worse or better, just that it was already indeed possible to ignore PNR without this endpoint. |
There was a problem hiding this comment.
Please undo all style changes fo this PR. You can make a separate pull request for any style changes, but I don't want the alignment of variables or the array declarations on a newline.
Some of the style changes you've made, like extra spaces or adding trailing comma's are fine though. But in a separate PR.
tests/Amadeus/ClientTest.php
Outdated
| @@ -35,22 +35,24 @@ class ClientTest extends BaseTestCase | |||
| { | |||
| public function testCanCreateClient() | |||
| { | |||
| $par = new Params([ | |||
There was a problem hiding this comment.
Everywhere in this library we use his construct of ([ 'the' => 'array' ]), so I don't want to have this changed in just this one file.
tests/Amadeus/ClientTest.php
Outdated
| 'responseHandler' => $this->getMockBuilder('Amadeus\Client\ResponseHandler\ResponseHandlerInterface')->getMock() | ||
| ]); | ||
| $par = new Params( | ||
| [ |
There was a problem hiding this comment.
These changes should be undone (I won't repeat this comment from now on)
tests/Amadeus/ClientTest.php
Outdated
| @@ -168,14 +174,18 @@ public function testWillGetNullFromGetLastReqResHeadersWhenNoCallsWerMade() | |||
|
|
|||
| public function testCanDoDummyPnrRetrieveCall() | |||
| { | |||
| $mockedSendResult = new Client\Session\Handler\SendResult(); | |||
| $mockedSendResult = new Client\Session\Handler\SendResult(); | |||
There was a problem hiding this comment.
Don't align the = with lines above/below, we don't do that anywhere in the library and I'd like to keep it that way.
There was a problem hiding this comment.
Please undo similar changes in other places.
|
I've revert all style changes. Sorry for that, it's a habit. |
|
Thanks for contributing! |
We implementing the PNR_Ignore Call to use it in certain Webservices in combination with transactions/sessions. Actually it is not possible to ignore an PNR in a single call but this is needed and also usefull for some workflows.
What we have done: