New Message Service_StandaloneCatalogue Integration #220

arvind-pandey · 2018-08-04T13:48:26Z

Hi,
Please review and share your feedback.
Thank you.

- Service_StandaloneCatalogue Message is added

New Message Service_StandaloneCatalogue implementation

ServiceStandaloneCatalogue Changes

DerMika

Please review the remarks I made.

DerMika · 2018-08-05T08:17:44Z

src/Amadeus/Client/RequestOptions/Service/StandaloneCatalogue/Passenger.php

+/**
+ * Passenger
+ *
+ * @package Amadeus\Client\RequestOptions\Fare\InformativePricing


If this is an exact copy of Amadeus\Client\RequestOptions\Fare\InformativePricing, then you should just use the existing class instead of copying it. I want as little as possible duplicate code in the library.

Hi, this is not exact copy of Amadeus\Client\RequestOptions\Fare\InformativePricing.
I made some change that is require of this request. Instead if Tatoo that is array data type, we need reference that is index for each passenger.

Okay, in that case it's perhaps better to extend from the InformativePricing class,

As suggested by you I extended InformativePricing and created new class name ServicePassenger.

DerMika · 2018-08-05T08:18:33Z

src/Amadeus/Client/RequestCreator/Converter/Service/StandaloneCatalogueConv.php

+ * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
+ */
+
+namespace Amadeus\Client\RequestCreator\Converter\Service;


According to the PSR-2 standard, there has to be an empty line between namespace declaration and use statements.

change done.

DerMika · 2018-08-05T08:19:55Z

src/Amadeus/Client/RequestCreator/Converter/Service/StandaloneCatalogueConv.php

+ {
+ return new Struct\Service\StandaloneCatalogue($requestOptions);
+ }
+}


According to the PSR-2 standard, there has to be an empty line following the closing bracket at the end of the file.

change done

DerMika · 2018-08-05T08:27:25Z

src/Amadeus/Client/RequestOptions/Service/StandaloneCatalogue/Passenger.php~

@@ -0,0 +1,61 @@
+<?php


What is the point of this file? It should be removed.

I meant the file with the tilde at the end (.php~)

DerMika · 2018-08-05T08:29:10Z

src/Amadeus/Client/RequestOptions/Service/StandaloneCatalogue/PricingOptions.php

+ * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
+ */
+namespace Amadeus\Client\RequestOptions\Service\StandaloneCatalogue;
+use Amadeus\Client\RequestOptions\ServiceIntegratedPricingOptions;


DerMika · 2018-08-05T08:34:49Z

src/Amadeus/Client/Struct/Service/StandaloneCatalogue/FlightInfo.php

@@ -0,0 +1,124 @@
+<?php


Same as above. No unnessary duplicate code.

We need FlightInfo.php here because of request parameter is different from one used in informative pricing request. We need instead of used in InformativePricing Request.

DerMika · 2018-08-05T08:35:08Z

src/Amadeus/Client/Struct/Service/StandaloneCatalogue/PassengerInfoGroup.php

@@ -0,0 +1,60 @@
+<?php


Same remark.

We need index of each passenger instead of group of passenger that is used in other request. For this we need this Class file.

DerMika · 2018-08-05T08:35:23Z

src/Amadeus/Client/Struct/Service/StandaloneCatalogue/SegmentInformation.php

@@ -0,0 +1,66 @@
+<?php


Same remark.

Done. Removed this file

DerMika · 2018-08-05T08:35:33Z

src/Amadeus/Client/Struct/Service/StandaloneCatalogue/SpecificTravellerDetails.php

@@ -0,0 +1,49 @@
+<?php


Same remark

We need index of each passenger instead of group of passenger that is used in other request. For this we need this Class file.

DerMika · 2018-08-05T08:35:43Z

src/Amadeus/Client/Struct/Service/StandaloneCatalogue/TravellerDetails.php

@@ -0,0 +1,47 @@
+<?php


Same remark

We need index of each passenger instead of group of passenger that is used in other request. For this we need this Class file.

DerMika · 2018-08-05T08:37:29Z

You will also have to make sure StyleCI passes and the Unittests pass.

You will also have to add unittests, your new code should have 100% code coverage.

…client

arvind-pandey · 2018-08-08T07:54:38Z

I have made the changes suggested by you, please review and share your feedback.

…client

arvind-pandey · 2019-01-09T06:33:29Z

Dear Mika,

Wish you a very happy new year!
We have made suggested changes and now Amadeus is also certified for this request.
I am requesting you to please review and merge the same accordingly.

Also regarding adding unit tests we don't have much clarity on the same so kindly advice if this is mandatory or we can go without it? Else Please give us some clarity so that we can proceed ahead.

As we have worked hard to achieve this, it would be joyous if you add this to your Repo.

DerMika · 2019-05-25T07:02:48Z

I'm sorry for the terrible delay, I haven't had the time recently to work on this project. I will see what I can do about the missing tests.

therealartz · 2019-05-27T20:45:13Z

Could you please provide sample XML sources of request and reply for current service?

I can write tests for this PR, but I don't have access to this message on Amadeus.

arvind-pandey · 2019-05-30T05:36:44Z

I'm sorry for the terrible delay, I haven't had the time recently to work on this project. I will see what I can do about the missing tests.

Dear Mika,

No problem, hope we can manage this now.

arvind-pandey · 2019-05-30T05:47:12Z

Could you please provide sample XML sources of request and reply for current service?

I can write tests for this PR, but I don't have access to this message on Amadeus.

serviceStandaloneCatalogueReqRes.zip
Hi Artem,

Thank you for your interest in current message.
Please find the attachment of request and response.

therealartz · 2019-06-03T12:11:21Z

Could you please give me access to push into your branch so I will be able to add tests?

arvind-pandey · 2019-06-06T10:37:25Z

Invitation is send.

therealartz · 2019-06-06T19:11:00Z

Oh, there's something weird with git history happened.

I tried to push into master (that PR branch, but IDK what's wrong, everything resetted).

Please, check this branch standalone_pricing and create new PR from that branch.
When I trying to merge this branch into master and push git says Everything up-to-date.

I'm sorry for that.

UPD: I resolved by merge directly on github. Seems everything is correct now.

Standalone pricing

therealartz · 2019-06-06T19:36:07Z

@DerMika I guess now it's finally ready to be merged!

DerMika · 2019-06-23T10:44:58Z

I will look through the last changes today or tomorrow. thanks for the hard work @therealartz and @arvind-pandey

arvind-pandey · 2019-06-24T10:34:30Z

thank you for approval

arvind-pandey and others added 4 commits August 4, 2018 18:56

new message serviceStandaloneCatalogue

227bfc4

Update list-of-supported-messages.rst

d08bfe9

- Service_StandaloneCatalogue Message is added

Update samples.rst

a06dcbe

New Message Service_StandaloneCatalogue implementation

Update samples.rst

0280980

ServiceStandaloneCatalogue Changes

DerMika requested changes Aug 5, 2018

View reviewed changes

DerMika added the new message label Aug 5, 2018

DerMika mentioned this pull request Aug 5, 2018

amadeus ancillary services #208

Closed

arvind-pandey added 16 commits August 6, 2018 17:37

changes

d9c475a

Merge branch 'master' of https://github.com/arvind-pandey/amadeus-ws-…

b4b080a

…client

change

acf7fa2

change

4bcb141

changes

4616da4

deleted

16c67c9

change

d2bc03c

changes

80e6a06

change

75b361d

change

966f851

change

7111c55

change

3a94c65

change

d2ce665

change

edcdbb2

change

0c0e0a4

change

431242a

arvind-pandey and others added 5 commits August 8, 2018 15:24

change

ed5fb9c

change

3f232c4

Update samples.rst

f456fe1

change

061208b

Merge branch 'master' of https://github.com/arvind-pandey/amadeus-ws-…

a7eb0bf

…client

arvind-pandey added 9 commits November 3, 2018 15:18

change for coverage

69437df

conflict resolve

911bd14

conflick resolved

611f0ad

conflick resolved

01d531e

conflick resolved

86e3cda

conflick resolved

5d4697c

conflick resolved

8ea8f31

conflick resolved

3638560

change

762658e

Merge branch 'master' into master

b002a3b

therealartz added 5 commits June 3, 2019 14:08

Fix sample

0989c12

Create response handler for Service_StandaloneCatalogue

dcdefcf

Add Client test of Service_StandaloneCatalogue

68d9f0d

Refactor doc blocks

7950fab

Added struct test

6b35d3f

therealartz force-pushed the master branch from b002a3b to a8b79e0 Compare June 6, 2019 18:59

Merge pull request #1 from arvind-pandey/standalone_pricing

bbdbaa2

Standalone pricing

DerMika approved these changes Jun 23, 2019

View reviewed changes

DerMika merged commit 80aa1ab into amabnl:master Jun 23, 2019

New Message Service_StandaloneCatalogue Integration #220

New Message Service_StandaloneCatalogue Integration #220

Conversation

arvind-pandey commented Aug 4, 2018

DerMika left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DerMika commented Aug 5, 2018

arvind-pandey commented Aug 8, 2018

arvind-pandey commented Jan 9, 2019

DerMika commented May 25, 2019

therealartz commented May 27, 2019

arvind-pandey commented May 30, 2019

arvind-pandey commented May 30, 2019

therealartz commented Jun 3, 2019

arvind-pandey commented Jun 6, 2019

therealartz commented Jun 6, 2019 • edited Loading

therealartz commented Jun 6, 2019

DerMika commented Jun 23, 2019

arvind-pandey commented Jun 24, 2019

therealartz commented Jun 6, 2019 •

edited

Loading