Implementation of FOP_ValidateFOP

[bimusiek]

Started working on implementation of FOP_ValidateFOP.

I will test it on our system, add some documentations and then it should be ready to release. 👍

[coveralls]

Coverage decreased (-0.7%) to 99.147% when pulling 0dbedcd on whatsahoy:mh/validate-fop into 533bb43 on amabnl:master.

[bimusiek]

@DerMika Any ideas why Travis fails?
Locally I am getting OK (604 tests, 5233 assertions) 😞

[DerMika]

The Travis build fails with a unit test on the response handler, getting unknown instead of ERR status

[DerMika]

Time: 23.31 seconds, Memory: 40.00MB
There was 1 failure:
1) Test\Amadeus\Client\ResponseHandler\BaseTest::testCanHandleFopValidateFopErrorResponse
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'ERR'
+'UNKNOWN'
/home/travis/build/amabnl/amadeus-ws-client/tests/Amadeus/Client/ResponseHandler/BaseTest.php:1427
FAILURES!
Tests: 604, Assertions: 5228, Failures: 1.

[bimusiek]

@DerMika I see the travis status, however I cannot reproduce locally. All tests pass on my machine :( And I made sure to parse these errors properly (based on CreateFOP)

[DerMika]

Posting this while on vacation by the way ;)

[bimusiek]

@DerMika GO AWAY! 🌞 GET SOME REST!

[DerMika]

Did you commit and push the XML sample message?

[DerMika]

I would also advise you to remove all personally identifiable information from your sample message.

[bimusiek]

There is only a name, I don't care about it :) Credit Card is dummy one.

I still have no clue why the tests fail on Travis. My guess is that HandlerValidateFOP is not called on Travis somehow. Could case sensitivity be an issue?

[DerMika]

Yes, those Travis builds are running on a Linux platform

[bimusiek]

Found the issue:

-        $result = $respHandler->analyzeResponse($sendResult, 'Fop_ValidateFOP');
+        $result = $respHandler->analyzeResponse($sendResult, 'FOP_ValidateFOP');

[coveralls]

Coverage increased (+0.0009%) to 99.843% when pulling 8961f86 on whatsahoy:mh/validate-fop into 533bb43 on amabnl:master.

[DerMika]

Thanks a lot for your contribution!