Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to retrieve PNR that is active in context #88

Merged
merged 4 commits into from
Aug 18, 2017

Conversation

bimusiek
Copy link
Collaborator

@bimusiek bimusiek commented Aug 15, 2017

I tested it and it works, but it is not usable for me 😢 However code is there, so maybe someone else will need it.

Btw, for future Amadeus explorers:

  • Airline is created after you save PNR and close the session...
  • Same thing with reservation company, it is filled with IATA code only after session is closed.

@coveralls
Copy link

coveralls commented Aug 15, 2017

Coverage Status

Coverage increased (+0.0001%) to 99.842% when pulling 572b5c7 on whatsahoy:pnr-retrieve-active into 533bb43 on amabnl:master.

@coveralls
Copy link

coveralls commented Aug 15, 2017

Coverage Status

Coverage increased (+0.0001%) to 99.842% when pulling b5d09b6 on whatsahoy:pnr-retrieve-active into 533bb43 on amabnl:master.

@DerMika
Copy link
Collaborator

DerMika commented Aug 15, 2017

Can you please move the test to Test\Amadeus\Client\Struct\Pnr\RetrieveTest?

@bimusiek
Copy link
Collaborator Author

@DerMika I based the test on testCanCreatePnrRetrieveMessage. I see in BaseTest you are testing the whole request building (which is ok, as I added some logic to building request for PNR_Retrieve).

I added another one in Test\Amadeus\Client\Struct\Pnr\RetrieveTest that tests the struct.

@coveralls
Copy link

coveralls commented Aug 18, 2017

Coverage Status

Coverage increased (+0.001%) to 99.843% when pulling 42d80b0 on whatsahoy:pnr-retrieve-active into 533bb43 on amabnl:master.

@DerMika
Copy link
Collaborator

DerMika commented Aug 18, 2017

Ah, I see. Thanks again :)

@DerMika DerMika merged commit 2d43d37 into amabnl:master Aug 18, 2017
DerMika added a commit that referenced this pull request Aug 18, 2017
@DerMika DerMika added this to the 1.5.0 milestone Aug 25, 2017
atomy pushed a commit to mlamm/amadeus-ws-client that referenced this pull request Nov 26, 2018
…warn-flag-on-end-transaction to master

* commit 'ca2e3fe81f885327c8e93420f8b61eced6b6e43d':
  - removed action-code 30 (treat warnings as errors) on transaction-end request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants