Multi Ticket functionality implemented in MasterPricer messages #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerMika
reviewed
Sep 15, 2017
| @@ -96,12 +96,13 @@ protected function loadPassenger($passenger, &$counter, &$infantCounter) | |||
| * @param FareMasterPricerTbSearch|FareMasterPricerCalendarOptions|TicketCheckEligibilityOptions $options | |||
| * @return void | |||
| */ | |||
| protected function loadNrOfPaxAndResults($options) | |||
| protected function loadNrOfPaxAndResultsAndMultiTicketWeights($options) | |||
There was a problem hiding this comment.
Oh god, these names are getting out of hand! :)
There was a problem hiding this comment.
I can change to loadNumberOfUnits 😄
There was a problem hiding this comment.
Nah, it's fine! Just when another option is added, we may have to reconsider the naming approach
|
You can also add an entry in the CHANGELOG if you want. Or I can do it too, it's the same to me. |
DerMika
changed the title
|
I changed the name of the function, added changelog and 1 small check for number of units (as I forgot before and realised just now) |
|
Thanks again for another contribution! |
|
I've released version 1.5.0, with all your changes! Thanks again! |
atomy
pushed a commit
to mlamm/amadeus-ws-client
that referenced
this pull request
Nov 26, 2018
…A-3169 to master * commit 'da2e4f736907b2c2a63dd69ccf20a15797b313b7': FA-3169: Update Fare_PricePNRWithBookingClass zu 16.1 in 1ASIWADMTBD - cleanup FA-3169: Update Fare_PricePNRWithBookingClass zu 16.1 in 1ASIWADMTBD - adding PRD wsdl FA-3169: Update Fare_PricePNRWithBookingClass zu 16.1 in 1ASIWADMTBD - adding test for Price_PNRWithBookingClass version - removed old versions from wsdl for PNR_WithBookingClass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 options in MasterPricer: