Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update branch_protection for provider v6.x #10

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

bazaah
Copy link

@bazaah bazaah commented Apr 16, 2024

We add three new attrs:

  1. force_push_bypassers
  2. lock_branch
  3. restrict_pushes

We only support the one-uple pattern for restrict_pushes, similar to
the previous blocks like required_status_checks.

In service of backwards compatibility we do check to see if a live
branch_protections_v4.push_restrictions array exists and use that as a
fallback, as this was the previous attr used for the same function in
integrations/github v4.

References: https://registry.terraform.io/providers/integrations/github/6.2.1/docs/resources/branch_protection

@bazaah
Copy link
Author

bazaah commented Apr 16, 2024

Hum suddenly ci/cd runs

@bazaah bazaah linked an issue Apr 16, 2024 that may be closed by this pull request
3 tasks
@bazaah bazaah force-pushed the feature/6x-branch-protection-attrs branch from d3f2441 to 07b04e6 Compare April 19, 2024 14:47
bazaah added 4 commits April 22, 2024 08:28
We add three new attrs:

1. force_push_bypassers
2. lock_branch
3. restrict_pushes

We only support the one-uple pattern for restrict_pushes, similar to
the previous blocks like required_status_checks.

In service of backwards compatibility we do check to see if a live
branch_protections_v4.push_restrictions array exists and use that as a
fallback, as this was the previous attr used for the same function in
integrations/github v4.

References: https://registry.terraform.io/providers/integrations/github/6.2.1/docs/resources/branch_protection
Enforce column=80 on doc comments, improve sentence structure and
layout, and improve the phrasing around what an 'actor' and 'entity' is,
in Github terms.
@bazaah bazaah force-pushed the feature/6x-branch-protection-attrs branch from 734e248 to 84f5931 Compare April 22, 2024 08:29
@bazaah bazaah merged commit 7b4b7a1 into main Apr 22, 2024
@bazaah bazaah deleted the feature/6x-branch-protection-attrs branch April 22, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update github_branch_protection resource config
2 participants