Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megasys1 gfx fixes and new working game #91

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

arcadez2003
Copy link
Contributor

Fixed gfx priorities 64th. Street - A Detective Story and Chimera Beast by hooking up the missing prios proms
Hooked up sprite buffering to fix some shaky sprites which affected all games on this system
Added new correct sound rom for Kick Goal
Added support for In Your Face

Fixed gfx priorities 64th. Street - A Detective Story and Chimera Beast by hooking up the missing prios proms
Hooked up sprite buffering to fix some shaky sprites which affected all games on this system
Added new correct sound rom for Kick Goal
Added support for In Your Face
@amadvance
Copy link
Owner

Hi @arcadez2003

I see that you closed some PullRequests. Any reason for that ?
I just went back from holiday, and I was ready to merge them.

Ciao,
Andrea

@arcadez2003
Copy link
Contributor Author

Hi @arcadez2003

I see that you closed some PullRequests. Any reason for that ? I just went back from holiday, and I was ready to merge them.

Ciao, Andrea

Hi there @amadvance

Hope you enjoyed your holidays i'll bet you went somewhere cooler to escape the Italian heatwave which is something
we silly Scots tend to do in reverse eg we'll head right into a heatwave :)

Anyway with regards to the commits the code compiles fine in my other projects but for some reason this core was complaining about VIDEO_EOF not being declared correctly after i ported the changes across, and try as i might i
could not get rid of those build errors hence i thought it best to close the pull req's for now.

I had hoped to work with Scandy to see if we could get the code to build in his fork before pushing it to the mainline
"as there are some nice fixes and improvements to be had here for some rather popular games" but he never replied
to my message so i guess he's too busy just now.

Without rabbiting on here im not good with this GIT hence i tend to push each commit seperately i've noticed when
you do this sometimes errors occur which are usually ironed out after all the changes have been added but in this
case they didn't seem too hence i thought it best to backtrack.

Tell ya what i'll reopen the megasys1 updates and hopefully together when you have the time between us we can
iron out any issues which might or hopefully might not crop up.

Regards

@arcadez2003 arcadez2003 reopened this Aug 9, 2023
@arcadez2003 arcadez2003 reopened this Mar 21, 2024
@arcadez2003
Copy link
Contributor Author

arcadez2003 commented Mar 21, 2024

@amadvance let's try these commits again in the sense we never merged them into the release build
to see if everything would iron out in the end, i can always revert should there be build failures.

There are some good fixes here plus a new working game it would be a shame to waste these.

@amadvance amadvance merged commit b87594f into amadvance:master Mar 21, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants