Refactor code of WithFirstSpliterator #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add couple of deprecated methods for the sake of benchmarking; add benchmarks to prove the absence of performance regression after refactoring; fix javaDocs for StreamEx.withFirst methods (actually this is not directly related to refactoring, as semantics was not changed)
amaembo
requested changes
Sep 6, 2020
|
|
||
| private ReentrantLock lock; | ||
| /* package */final class WithFirstSpliterator<T, R> extends CloneableSpliterator<R, WithFirstSpliterator<T, R>> { | ||
| private static final Object lock = new Object(); |
There was a problem hiding this comment.
Your solution uses a single shared lock between all the spliterators, including totally independent that could possibly run in a separate thread pool. Sorry, but I cannot accept a pull-request that introduces a global lock.
There was a problem hiding this comment.
Indeed! My bad. Fixed this.
| @@ -1764,11 +1764,6 @@ public void forPairs(BiConsumer<? super T, ? super T> action) { | |||
| * <p> | |||
| * This is a <a href="package-summary.html#StreamOps">quasi-intermediate | |||
| * operation</a>. | |||
| * | |||
| * <p> | |||
| * The size of the resulting stream is one element less than the input | |||
There was a problem hiding this comment.
Thanks, indeed this should be changed. I forgot to update this part in version 0.6.4 when semantics of withFirst changed. However, it's better to say that the size remains the same than removing this completely. I will apply this change separately.
amaembo
added a commit
that referenced
this pull request
Sep 6, 2020
|
is this good now ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the code of WithFirstSpliterator:
acceptmethod (as it is a one-liner) to improve readabilityTests are keep passing, perfomance is the same (even a bit higher):
WithFirstSpliteratorOldclass and new@Deprecatedmethods & benchmarks are subject for removal upon merging this PR.