Correcting a comment in EntryStream.java #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in EntryStream.java, in the ofPairs() methods, there was an error in the formula for the size of the output EntryStream.
kivanval
changed the title
|
Thank you, merged.
Because it does not produce any combinations (with arbitrary r), but a partial case with r = 2. There's |
|
By the way, there's the same problem in documentation in |
Can you change it yourself or do I have to make another pull request? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in EntryStream.java, in the ofPairs() methods, there was an error in the formula for the size of the output EntryStream.
The ofPairs() methods by its nature calculate all possible combinations of list items (Actually, I don't really understand why it's not called ofCombinations()).
The formula for combinations is as follows:
If we take our specific case, where r = 2, the formula will look like this:
